Re: [Success] XEmacs 21.5-b9 "brussels sprouts" (+CVS-20021117) i586-pc-win32

Ben> stephen, can you explain a bit as to what's going on here and Ben> what you did? that would help me a lot if i go in and try to Ben> fix it right. This I can explain. See below. The tests/automated/mule-test.el failures: This I can't, that's why I referred it to you. I haven't any idea yet what's going on with Mule in 21.5; if the test is not failing in 21.4 (and it's not), I'll need to book up a lot to figure it out. The dired / truename stuff: What's happening to Adrian is that under Windows 2000, native build (you should fill in more details about your environment, Adrian, since Ben evidently isn't seeing it) xemacs -vanilla M-x dired produces the error. The original patch by Dan Holmsand 2001-03-20 Dan Holmsand <dan(a)eyebee.com&gt; * realpath.c (xrealpath): Make file-truename work with symlinks to /cygdrive paths on cygwin. Always lowercase drive-letters on native windows. (cygwin_readlink): Don't try to find canonical filename unless file exists. hardcoded detection of weird characters in file names. I just changed the hardcoding with the patch below, but this isn't satisfactory for 21.5 because I know nothing about Windows filenames at this point, and it probably should be abstracted, and it surely isn't Mule-safe. Not to mention that I suspect the errors returned are bogus. Index: src/ChangeLog =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/src/ChangeLog,v retrieving revision 1.290.2.28.2.11 diff -u -U0 -r1.290.2.28.2.11 ChangeLog --- src/ChangeLog 9 Oct 2002 13:19:12 -0000 1.290.2.28.2.11 +++ src/ChangeLog 10 Oct 2002 13:10:33 -0000 ＠＠ -0,0 +1,6 ＠＠ +2002-10-10 Stephen J. Turnbull <stephen(a)xemacs.org&gt; + + * realpath.c (win32_readlink): Try to fix truename of wildcard bug. + + * emacs.c (shut_down_emacs): Improve crash message. + Index: src/realpath.c =================================================================== RCS file: /pack/xemacscvs/XEmacs/xemacs/src/realpath.c,v retrieving revision 1.7.2.2 diff -u -r1.7.2.2 realpath.c --- src/realpath.c 22 Aug 2002 10:58:34 -0000 1.7.2.2 +++ src/realpath.c 10 Oct 2002 13:10:50 -0000 ＠＠ -90,9 +90,16 ＠＠ assert (*name); /* Sort of check we have a valid filename. */ - if (strpbrk (name, "*?|<>\"") || strlen (name) >= MAX_PATH) + /* #### can we have escaped shell operators in a Windows filename? */ + if (strpbrk (name, "|<>\"") || strlen (name) >= MAX_PATH) { errno = EIO; + return -1; + } + /* #### can we have escaped wildcards in a Windows filename? */ + else if (strpbrk (name, "*?")) + { + errno = EINVAL; /* this valid path can't be a symlink */ return -1; } -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.