hi,
latest CVS does not compile for me, very related to that:
../lwlib/liblw.a(xlwradio.o): In function `RadioSize':
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwradio.c:535: undefined
reference to `Max'
../lwlib/liblw.a(xlwgauge.o): In function `GaugeSize':
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:1021: undefined
reference to `Max'
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:1027: undefined
reference to `Max'
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:968: undefined
reference to `Max'
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:1054: undefined
reference to `Max'
../lwlib/liblw.a(xlwgauge.o):/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:1060:
more undefined references to `Max' follow
but it raises yet another question: i see loads of patches around here,
some more in xemacs-patches, but not all make it into CVS, and some are
_dropped_ and some other are put on top of some others....
so, what should i do? apply a patch everytime i need it, or wait for one
of you guys to put in into CVS.
in a way i wouldn't mind applying patches, but then if you commit
something with the slightest difference, CVS will tell me i modified the
file, which i don't want to, because i'd have to remember everytime i
apply a patch, and then remove the changes to apply those from CVS
(which i assume would be more up-to-date).
what should we do with all those patches, really?
applying them is not an option if you also want to use CVS, or am i
again wrong ? (funny the number of times i'm proven wrong here, i guess
it must be what people call 'the real word' :)
On Wed, Sep 01, 1999 at 09:33:29AM +0100, Andy Piper wrote:
At 09:38 AM 9/1/99 +0200, Michael Sperber [Mr. Preprocessor] wrote:
>
>Yo Andy,
>
>thanks for the patch!
>
>>>>>> "Andy" == Andy Piper <andy(a)xemacs.org> writes:
>
>Andy> [1 <text/plain; us-ascii (7bit)>]
>Andy> Does this fix it?
>
>Almost. There are uses of `Max' in xlwtabs.c---trivial enough to fix
>with this:
>
>--- lwlib/xlwtabs.c.orig Wed Sep 1 09:34:12 1999
>+++ lwlib/xlwtabs.c Wed Sep 1 09:34:38 1999
>@@ -63,7 +63,9 @@
> #include <X11/StringDefs.h>
> #ifdef HAVE_XMU
> #include <X11/Xmu/Misc.h>
>-#endif
>+#else /* #if !HAVE_XMU */
>+#define Max(x, y) (((x) > (y)) ? (x) : (y))
>+#endif /* !HAVE_XMU */
> #include "xlwtabsP.h"
> #include "xlwgcs.h"
>
>---and uses of `XA_TEXT' in xlwgauge.c which I don't know to fix.
Ok. I've done this slightly differently. The XA_TEXT thing should be gone.
At a cvs server near you shortly....
andy
1999-09-01 Andy Piper <andy(a)xemacs.org>
* xlwgauge.c: use xmu.h
* xlwcheckbox.c: ditto.
* xlwradio.c: ditto.
* xmu.h: define Xmu/Misc.h things.
--------------------------------------------------------------
Dr Andy Piper
Senior Consultant Architect, BEA Systems Ltd
--
# Stef Epardaud, # There is no limit to the power of computing ...
# Java Defeater # ... except men maybe ?
# Earth # Lunatech Research,
# Solar System # soon we will quit researching and start finding...