Re: TLS implementation
On Thu, Dec 11, 2014 at 1:55 AM, Mats Lidell <matsl(a)xemacs.org> wrote:
>>>>> Jerry James <james(a)xemacs.org> writes:
> A month goes by ....
Another month or so goes by and I tried to build it on my old SuSE
still using openssl-0.9.8! This is what happens.
----------------------------------------------------------------------
make[1]: Entering directory `/src/xemacs/work/testing/src'
gcc -c -Wall -Wno-switch -Wundef -Wsign-compare -Wno-char-subscripts -Wpacked -Wshadow
-Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes
-Wdeclaration-after-statement -Wunused-parameter -g -Demacs -I.
-I/src/xemacs/work/testing/src -DHAVE_CONFIG_H -I/usr/include/freetype2 tls.c
tls.c: In function \u2018init_tls\u2019:
tls.c:1114: error: \u2018SSL_OP_NO_COMPRESSION\u2019 undeclared (first use in this
function)
tls.c:1114: error: (Each undeclared identifier is reported only once
tls.c:1114: error: for each function it appears in.)
tls.c:1117: error: \u2018SSL_MODE_RELEASE_BUFFERS\u2019 undeclared (first use in this
function)
make[1]: *** [tls.o] Error 1
make[1]: Leaving directory `/src/xemacs/work/testing/src'
----------------------------------------------------------------------
From searching the net I suspect this is because we are not compatible
with 0.9.8. What to do, disable tls if openssl is to old or make it
compatible? I'm in favor of the former.
Me, too. The code would need some significant work to operate
properly with openssl < 1.0.0. Does this work for you?
diff -r bf1e13811159 configure.ac
--- a/configure.ac Fri Dec 19 15:01:46 2014 -0700
+++ b/configure.ac Fri Dec 19 15:28:55 2014 -0700
＠＠ -5344,7 +5344,14 ＠＠
[XE_DIE("Required NSS support cannot be provided.")])
elif test "$with_tls" = "openssl"; then
AC_CHECK_HEADER([openssl/ssl.h],
- [AC_CHECK_LIB(ssl, SSL_library_init, [with_tls=openssl],
+ [AC_CHECK_LIB(ssl, SSL_library_init,
+ [AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
+#include <openssl/ssl.h>
+#if OPENSSL_VERSION_NUMBER < 0x1000000fL
+#error OpenSSL is too old to use
+#endif
+ ]])], [with_tls=openssl],
+ [XE_DIE("Required openssl support cannot be provided.")])],
[XE_DIE("Required openssl support cannot be provided.")])],
[XE_DIE("Required openssl support cannot be provided.")])
fi
＠＠ -5359,7 +5366,14 ＠＠
fi
if test "$with_tls" = "yes"; then
AC_CHECK_HEADER([openssl/ssl.h],
- [AC_CHECK_LIB(ssl, SSL_library_init, [with_tls=openssl], [with_tls=no])])
+ [AC_CHECK_LIB(ssl, SSL_library_init,
+ [AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
+#include <openssl/ssl.h>
+#if OPENSSL_VERSION_NUMBER < 0x1000000fL
+#error OpenSSL is too old to use
+#endif
+ ]])], [with_tls=openssl], [with_tls=no])],
+ [with_tls=openssl], [with_tls=no])])
fi
if test "$with_tls" != "no"; then
AC_DEFINE(WITH_TLS)
Regards,
--
Jerry James
http://www.jamezone.org/
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta