Stephen J. Turnbull writes:
21.4 21.5 VETO
This was a couple months ago but AFAIK not yet resolved?
dont believe so
i can re-do these patches
which branch do you want me to diff them with ??
[snip]
Peter> should athena be the default widget set used ???
_Motif_ is the default widget set used. This may not be appropriate
now with very few newbies using Motif, and many many newbies using
Athena variants under Linux. But I'm not going to change it in the
stable branch, and I think we should be careful even on the trunk.
Maybe if no widget_set after Motif, try Athena then.
that sounds good
For now, I think that rather than try to do something
"smart", we should
default to telling the user he's shooting himself in the foot. In the
part of configure that creates Installation, where the widget set is
announced, if there is no widget set we should check for a window
system. If there is a window system, warn the user that most modern
window systems do support widgets and the missing functionality will
be very noticable. Use --with-widgets, blah blah blah.
oki
A timely patch to that effect would go into 21.4.5; it'll have to
wait
for 21.4.6 or later if it's up to me. ;-)
Peter> patch included below (this is my first patch so let me know
Peter> if i did it wrong)
The patch itself is fine. Do include a ChangeLog, either plaintext or
as a [cvs] diff -U 0. Diffs should be taken from the top directory
when possible. Doesn't matter here, but for src/alloc.c, the Index
line should be
Index: src/alloc.c
not
Index: alloc.c
--
-------------------------------------------------------------------------
Peter (Rendhalver)
XEmacs Advocate
Perl Hacker
Apache God
FreeBSD Devote
rendhalver(a)users.sourceforge.net
There are only two things that are infinite,
the universe and human stupidity,
and i am not certain about the former
- Albert Einstein
-------------------------------------------------------------------------