Re: [AC] [PACKAGES (gnus)] Remove Gnus' dependence on fsf-compat + Jerry's macro patch
Steve Youngs <sryoungs(a)bigpond.net.au> writes:
This patch means that Gnus no longer requires fsf-compat.
Have you actually checked that the Gnus code no longer uses things
from fsf-compat? Last time I looked, Gnus (and other packages
developed independently or carelessly synched) introduced many subtle
FSF-isms that have gone in unnoticed because fsf-compat was silently
blessed by its inclusion in the SUMOs.
This change in particular is suspicious:
Index: lisp/gpg.el
[...]
-(require 'timer)
+(if (featurep 'xemacs)
+ (require 'itimer)
+ (require 'timer))
(eval-when-compile (require 'cl))
Unless `gpg.el' has changed significantly from the version I have,
this change cannot be correct. gpg.el uses timer functions all over
the place without checking whether they're defined.
You have to either *really* port the file over to XEmacs's API's or
leave the `require', thereby acknowledging the dependence on
`timer.el' and consequently fsf-compat. That's how it works.