|--==> "BP" == Brian Palmer <bpalmer(a)leland.stanford.edu> writes:
BP> Steve Youngs <youngs(a)xemacs.org> writes:
>I think I've been staring at this for too long, I just
can't figure
>out what is going wrong here. :-(
>
>Take a look at this function and tell me why it *only* commits the
>Makefile and *not* the ChangeLog...
BP> Isn't this because you're missing a space at the end of
BP> 'pkg-log-entry-inc-ver ? It's trying to run
BP> cvs commit -m "Increment VERSION in Makefile"ChangeLog
Makefile
BP> rather than
BP> cvs commit -m "Increment VERSION in Makefile" ChangeLog
Makefile
Spot on! Thanks for showing me what was right in front of my face all
along.:-) When are you coming to collect your beer?
BP> On a side note, what is the purpose of the pattern
BP> (let ((files (setq files "ChangeLog Makefile"))))
BP> ? It seems like the setq is defeating any use of let there:
Desperation in trying to get to the bottom of the above missing space
problem. Thanks for reminding me, I'll fix them up.
BP> --- pkg-build.el 2002/06/01 20:56:41 1.6
BP> +++ pkg-build.el 2002/06/02 00:50:52
BP> @@ -136,7 +136,7 @@
BP> :group 'pkg-build
BP> :type 'string)
BP> -(defcustom pkg-log-entry-inc-ver "\"Increment VERSION in Makefile
\""
BP> +(defcustom pkg-log-entry-inc-ver "\"Increment VERSION in Makefile
\" "
BP> "*CVS commit log entry.
Thanks for the patch. I decided to remove the space from
'pkg-log-entry-inc-ver' and add it in the command line in the function.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|