Re: Can't compile 21.4.5
On 24 Oct 2001, Stephen J. Turnbull yowled:
steve＠tleeps18:/var/tmp/XEmacs/xemacs-21.4.5$ diff -u
src/window.c{~,}
--- src/window.c~ Tue Oct 23 17:35:39 2001
+++ src/window.c Wed Oct 24 10:36:29 2001
＠＠ -2689,7 +2689,8 ＠＠
case UNDEDICATE_BUFFER:
{
- if ((XBUFFER (p->buffer) == XBUFFER (obj)) &&
(p->dedicated))
+ if ((XBUFFER (p->buffer) == XBUFFER (obj))
+ && !NILP (p->dedicated))
p->dedicated = Qnil;
break;
}
Ben, is the fix correct? Nix, if we're going to set to nil anyway,
why is the !NILP needed?
As Ben says, it isn't. It's historical cruft from the first version of
the patch (the buggy one that dededicated all windows whenever you went
down this code path, instead of just dededicating windows onto the
buffer you were killing) and I should have zapped it. Oops.
--
`You're the only person I know who can't tell the difference
between a pair of trousers and a desk.' --- Kieran, to me