Re: [Bug: 21.4.22] weird file corruption with utf8 charset
Dear Steve et al,
I tried to re-start this conversation a little while ago; is this thing on?
XEmacs 21.4 EOL, take 2:
On Thu, Sep 4, 2014 at 11:26 PM, Stephen J. Turnbull <stephen(a)xemacs.org> wrote:
Stephen J. Turnbull writes:
Ouch. The version of libpng I have in my -I path is v1.6, and our
code tries to access declared but not defined structs (as of v1.5).
For this bug I'll work around by configuring --without-png.
However, I think we should backport
2011-03-14 Aidan Kehoe <kehoea(a)parhasard.net>
* glyphs-eimage.c (png_instantiate):
Update the PNG handling code to work with versions of the library
where the png_info structure is no longer visible. Thank you for
the report, Robert Delius Royar.
from 21.5.
Vin, any objections? Note that the libpng docs claim that the
relevant "png_get_*" and "png_set_*" functions have been available
since libpng v1.0 or so, and I would imagine that by now pretty much
everybody has libpng v1.2.
First off, src/ChangeLog says this:
2012-07-12 Vin Shelton <acs(a)xemacs.org>
* glyphs-eimage.c: Fix this so it compiles with libpng-1.5.10.
Thanks to Aidan, Julian and Hans de Graaff.
I expected that would take care of the private fields in the
structures, but apparently it does not.
Secondly, I have no objections to patches to fix this and the clang
3.4 issue you identified elsewhere, but shouldn't we call "Olly, olly,
oxen-free" and declare 21.4.23 to be the end of the line? Sooner or
later, we have to let Grandma RIP.
- Vin
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta