Re: [PATCH] moving Open URL menu to browse-url
Steve Youngs <youngs(a)xemacs.org> writes:
|--==> "SJ" == Simon Josefsson <jas(a)extundo.com>
writes:
SJ> torkel(a)acc.umu.se (Björn Torkelsson) writes:
>>Well, why keep stuff in the core that depends on a package, designed for
>>one package only, and (probably) needs to be updated when the package
>>change? Isn't the idea to just keep the "core" functionality in
the core
>>and the rest as packages?
SJ> I agree, just wanted to see if anyone disagreed. :-)
I agree too.
Great :-)
SJ> So, is this OK? (CVS history seem to be limited so I
couldn't check
SJ> the copyright situation, I simply copied it from menubar-items.el.)
You won't get any opposition from me. Did you remove this code from
menubar-items.el as well? (no point in duplication).
I will make a patch for removing the stuff from menubar-items.el. But I
think that the updated mail-lib package should be in at least pre-release
before menubar-items is updated. (not that browse-url-xemacs is in
cvs/mail-lib yet. Hopefully I will send a patch for b-u-x later today).
Are there any guidelines for adding new files to packages?
/torkel