William M. Perry writes:
2) Static variables always scare me in XEmacs - most of those should
be in
either the GTK device structure, or the GTK frame structure. Especially
if GTK ever gets real mulit-display support, the atoms on each display
could be different.
I've added one previously static to the gtk_frame and was
able to get rid of the others through better coding. Should
be much more portable, robust and compliant now that's it's
more than a proof of concept. Also managed to severely speed
up some stuff.
What are the 'extreme bogosity' hard-coded offsets for?
They've gone.
What about calling Fredraw_frame(frame,Qt) instead of directly
calling
gtk_redraw_exposed_area(f,0,0,32000,32000)?
Caused extreme flicker in earlier test, will try vs the optimized
version later.
I've also added shading/tinting if imlib is present and fixed
a nasty memory leak.
Will submit patch as soon as I find a good set up for the
variables.
Have a nice weekend,
Azundris