Re: problems with your patch
Uwe Brauer writes:
>> On Mon, 28 Nov 2011 23:50:30 +0900, "Stephen J.
Turnbull" <stephen(a)xemacs.org> wrote:
> Uwe Brauer writes:
>> - I am trapped in 21.5.29, because I need the xsymbol
>> patch you once send me (and saved my life :-D ), but
>> which I cannot apply to more recent versions of
>> 21.5.X.
> I don't see why not. It might take some adjusting of the patch.
Before I start to discuss this patch, why can't you apply the
patch for the official and all future release?
We've discussed that, repeatedly. Summary: it's the wrong thing to do
IMO; the right thing is to fix x-symbol, which is what is broken. And
it is likely to break again because the MATCHSPEC API probably needs
to be changed again anyway.
Why the patch I gave you for x-symbol didn't work for you, I still
don't know. You just gave up on it and went back to the patched core
because that worked for you. Well, it doesn't any more.
Aidan may decide he wants to revert his patch or apply mine. But if
so, he's the one to do it.
There are quite some changes in specifier.c. Can you give me
a hint? If not I will try to figure it out in the coming
days myself.
Those changes were done by Ben Wing and I'm not really sure why, so I
can't really help much with the 21.5.29 -> 31 changes.
My patch was very simple, though. I defined a function to check and
if necessary convert the MATCHSPEC argument, and then used it in
several functions (probably instead of the macro CHECK_CONS, although
I forget the details, anyway, it needs to be used instead of any
type-checking of the MATCHSPEC argument). I gather Ben changed the
signature of some functions to not use MATCHSPEC anymore; those
functions won't need the change any more.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta