Re: [Bug: 21.5-b33] warning when exiting Gnus isearch
Michael Sperber writes:
> (23) (error/warning) Error in `pre-command-hook'
(resetting to nil): Attempt to throw outside of function:To catch `exit' with value
`nil'
I'm pretty sure I fixed that one here (post-b33):
2013-02-22 Michael Sperber <mike(a)xemacs.org>
* event-stream.c (post_command_hook): Don't complain about throws
out of `post-command-hook'. This is quite common, for example to
exit the minibuffer.
Mike K. is seeing a throw out of PRE-command-hook, not POST-command-hook.
Are you sure this approach of just suppressing the warning is a good
idea? What Mike K is seeing seems to be an issue with isearch
thinking it's in a recursive edit when it's not.
I don't know if it will help, but the patch below seems like a better
idea to me.
# HG changeset patch
# Parent ff13c44ce0d92d2872eb38404c9c076628c3301d
Accurately detect recursive edit.
Avoid throw to 'exit when not in recursive edit.
diff -r ff13c44ce0d9 -r f478c6c7528c lisp/ChangeLog
--- a/lisp/ChangeLog Wed Apr 24 20:16:14 2013 -0400
+++ b/lisp/ChangeLog Sat Apr 27 18:14:04 2013 +0900
＠＠ -1,3 +1,7 ＠＠
+2013-04-27 Stephen J. Turnbull <stephen(a)xemacs.org>
+
+ * isearch-mode.el (isearch-done): Accurately detect recursive edit.
+
2013-03-02 Michael Sperber <mike(a)xemacs.org>
* bytecomp.el (byte-compile-if): Port this patch from GNU Emacs:
diff -r ff13c44ce0d9 -r f478c6c7528c lisp/isearch-mode.el
--- a/lisp/isearch-mode.el Wed Apr 24 20:16:14 2013 -0400
+++ b/lisp/isearch-mode.el Sat Apr 27 18:14:04 2013 +0900
＠＠ -687,7 +687,7 ＠＠
(run-hooks 'isearch-mode-end-hook)
- (and (not edit) isearch-recursive-edit (exit-recursive-edit)))
+ (and (not edit) (> command-loop-level 0) (exit-recursive-edit)))
(defun isearch-update-ring (string &optional regexp)
"Add STRING to the beginning of the search ring.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta