>>>> "Jan" == Jan Vroonhof
<vroonhof(a)math.ethz.ch> writes:
Jan> "Stephen J. Turnbull" <turnbull(a)sk.tsukuba.ac.jp> writes:
> as the test for being the default face can be done in
> `face-spec-set', custom doesn't use `reset-face' anywhere else
> that I could find. So I don't know what the right fix is.
Jan> I think at the very least for 21.0 changing face-spec-set
Jan> would be a good solution. It may be kludge but at least fixes
Jan> two annoying bugs one of them slamming directly in the face
Jan> of newbies. The question is, is there any chance of it
Jan> breaking anything.
Probably not. As far as I can tell, `reset-face' is a general
facility designed into faces, but was never used until
`face-spec-set', which I believe is a Custom facility.
`face-spec-set' is used only by Custom, and only in one or two places.
I don't have the entire SUMO package, but I do have about 30 packages
plus the core Lisp, and grepping through those shows only the hits
I've mentioned. Now that I've studied Custom a little bit, I'm fairly
confident that my original patch would not break any existing code
(but can't be sure, of course), and rather more confident that
changing `face-spec-set' won't break anything else, since it is a
Custom internal function.
Changing `face-spec-set' is the safer, more conservative approach. I
don't like the third idea of saving 'default for reasons discussed in
a separate post.
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
__________________________________________________________________________
__________________________________________________________________________
What are those two straight lines for? "Free software rules."