Re: Compilation failure in events.c with latest GC patches and --use-kkcc
David Bush wrote:
This is building on Cygwin.
I get this error:
gcc -c -I/usr/lib/../include/noX -I/usr/lib/../include/noX -g -O3 -Wall -Wno-switch
-Winline -Wmissing-prototypes -Wsign-compare -Wshadow -Wpointer-arith -Demacs -I.
-DHAVE_CONFIG_H -fno-caller-saves -fvtable-thunks events.c
events.c: In function `event_equal':
events.c:447: sizeof applied to an incomplete type
It appears that the HAVE_MS_MSWINDOWS section should look more like
the X and Gtk cases:
#ifdef HAVE_MS_WINDOWS
if (CONSOLE_MSWINDOWS_P (con))
return (XMAGIC_DATA_MSWINDOWS_EVENT (EVENT_DATA(e1)) =
^
|
Should be '==' ------------------------------------------------+
XMAGIC_DATA_MSWINDOWS_EVENT (EVENT_DATA (e2)));
#endif
I'll submit a patch if others think this looks correct.
Looks good to me. XEmacs thinks the underlying data is an int (actually
Win32 defines it to be a UINT - see mswindows_enqueue_magic_event() -
but never mind) so it's always OK to do a straight comparision with ==.
Jonathan.
--
Jonathan Harris | jhar(a)tardis.ed.ac.uk
London, England | Jonathan.Harris(a)symbian.com