Re: I fell off the 'net; SUMO in a day or three?

xemacs-review is redundant once we're on xemacs-beta, isn't it. mb> /bin/sh: -c: line 1: syntax error near unexpected token `;' mb> /bin/sh: -c: line 1: `for dir in ; do make mb> STAGING=/project/xemacs/ws/xemacs-packages/../Mule-Packages -C mb> ${dir} install; done' This is a sh-ism-in-Makefile syntax bug. The patch below (actually, the hunks starting with line 49) fix the bug, and may actually do something sensible with the whole process. I never had time to investigate whether this is the right thing. It also has some editorial comments which may or may not be of use to people who actually hack package Makefiles. Index: Makefile =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs-packages/Makefile,v retrieving revision 1.15 diff -u -r1.15 Makefile --- Makefile 2000/06/04 10:22:02 1.15 +++ Makefile 2001/01/08 05:52:20 ＠＠ -17,12 +17,15 ＠＠ SUBDIRS = libs comm games prog wp os oa -# Use a Local.rules file to specify what you wish to have installed +# This is evile, isn't it? XEMACS_PACKAGES_BASE := $(shell pwd) - +# This is obnoxious; I don't see why it is necessary. The real problem is +# macro calls, since macro definitions must be available to the byte- +# compiler. Macros that call macros, maybe? all:: all-bytecompile +# Use a Local.rules file to specify what you wish to have installed include Local.rules.mk -include Local.rules ＠＠ -49,14 +52,16 ＠＠ World: distclean install install: all -ifneq ($(MULE_PACKAGES),'') - for dir in $(MULE_PACKAGES); do \ - $(MAKE) STAGING=$(MULE_STAGING) $(MFLAGS) -C $${dir} install; \ - done +ifneq ('$(MULE_PACKAGES)','') + $(MAKE) STAGING=$(MULE_STAGING) PACKAGES="$(MULE_PACKAGES)" \ + $(MFLAGS) -C mule install endif -ifneq ($(XEMACS_PACKAGES),'') - for dir in $(XEMACS_PACKAGES); do \ - $(MAKE) STAGING=$(XEMACS_STAGING) $(MFLAGS) -C $${dir} install; \ +ifneq ('$(XEMACS_PACKAGES)','') + for dir in $(SUBDIRS); do \ + [ "$${dir}" != "mule" ] \ + && $(MAKE) STAGING=$(XEMACS_STAGING) \ + PACKAGES="$(XEMACS_PACKAGES)" $(MFLAGS) \ + -C $${dir} install; \ done endif ＠＠ -77,3 +82,4 ＠＠ for dir in $(SUBDIRS); do \ $(MAKE) $(MFLAGS) -C $${dir} distclean; \ done + -- University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091 _________________ _________________ _________________ _________________ What are those straight lines for? "XEmacs rules."