Re: [PATCH] Frame crash and extra minibuffers fixes
Greg Klanderman <greg(a)alphatech.com> writes:
>> Steve, was this to fix a bug or did it just look wrong?
sb>
sb> It was to fix a bug. `called_from_delete_device' can never be less
sb> than 0 so it is a degenerate comparison.
The bug being that called_from_delete_device can never be negative,
or
that this code not being run was actually causing a problem for someone?
The former.
>> I see nowhere that function is called with other than 0 or 1,
>> so maybe this code should just be ifdef'd out or removed?
sb>
sb> Yes, reversing the patch I made is equivalent to `if (1)' so there
sb> little point to keeping that conditional if it is causing problems.
You mean `if (0)', of course...
Of course, oops.
Can you reproduce this:
xemacs -q
<split window, load 2 files>
M-x ediff-buffers
`Symbol's value as variable is void: allow-remote-paths'
quit ediff
M-x ediff-buffers again
Do you get spurious creation of a minibuffer only frame?
Both Kirill and I do.
I've applied half of Kirill's patch and #if 0'ed out the `if' I
changed and he reverted. There'll be a snapshot made tonight.