Re: --with-xfs and Emacs.ad
On Tue, 2002-08-27 at 04:20, Stephen J. Turnbull wrote:
Ville> If building with XFontSet support (--with-xfs), I think
it
Ville> would be neat to also get *menubar*FontSet stuff in
Ville> Emacs.ad enabled by default, instead of *menubar*Font.
Go ahead and apply the patch to 21.5. I'll have to take a look at it
before putting it in 21.4, but I think our code will handle this
whether it's with-mule or not.
But I don't think that patch does The Right Thing. The patch
unconditionally removes *menubar*Font entries in Emacs.ad, which I think
will screw people not building --with-xfs. As long as RH is building
--with-xfs, they can safely apply it.
Instead, I think the real fix would be to put the *menubar*Font stuff
and *menubar*FontSet things in Emacs.ad inside some #ifdef -like things,
and the build process would enable the correct one of those, based on if
XFontSet support is requested when building. Or if it doesn't hurt
anyone, maybe just enable both *Font and *FontSet by default.
If I knew how to do the #ifdef -like stuff, I would already have done
it. Too bad it's beyond my autoconf/Makefile skills, so please someone
pick this one it up...
Red Hat really really sucks. There is no excuse whatsoever for not
passing this kind of trivial patch back upstream. Even less for not
informing us about the Hannibal Lecter ld (both Debian and SuSE did,
by contrast).
:/ I've been working a bit with the spec file for the RPM they have in
rawhide, and as of now, AFAICT all my fixes to it have been applied
(except for upgrading to 21.4.9) in the latest RPM, 21.4.8-16 (not at
ftp.redhat.com yet). Maybe we'll see a pretty sane XEmacs in their next
version.
I think I'm going to go through the patches applied by the major
distros, and make a Hall of OSS Shame page, listing their NON-
contributions.
Hihi...
Anyway, to save you some trouble, here's the other patch (there are 2 in
total) RH applies to their XEmacs, I don't really have a clue if it's
useful or Bad. It's called "xemacs-21-cursor.patch", is pretty old and
looks like it applies to the GTK version (no, they're not building a GTK
XEmacs). I can forward comments upstream.
--- gtk-xemacs/src/redisplay-tty.c.cursor Tue Nov 28 18:24:15 2000
+++ gtk-xemacs/src/redisplay-tty.c Tue Nov 28 18:25:09 2000
＠＠ -1236,7 +1236,7 ＠＠
}
TTY_SD (c).cursor_visible = tgetstr ("ve", &bufptr);
- TTY_SD (c).cursor_normal = tgetstr ("vs", &bufptr);
+ TTY_SD (c).cursor_normal = tgetstr ("ve", &bufptr);
TTY_SD (c).init_motion = tgetstr ("ti", &bufptr);
TTY_SD (c).end_motion = tgetstr ("te", &bufptr);
TTY_SD (c).keypad_on = tgetstr ("ks", &bufptr);
--
\/ille Skyttä
ville.skytta at xemacs.org