Re: Pushing new vc towards regular packages tree

Ville Skyttä <scop(a)xemacs.org&gt; writes: Hi Ville! Whow, has it really been that long? I have also used it off and on for extended periods for my day-to-day work. My testing was basically limited to cvs and rcs. An interesting aspect of my testing may be that I used it for .gpg files under CVS together with crypt++ and easypg (easypg from CVS) and remote files via tramp under RCS. Things work nicely for the most part. For tramp I had to apply following quick patch but the issue needs to be investigated further. Why is following patch not necessary with the latest official vc package? diff -u c:\progra~1\xemacs\xemacs-packages\lisp\tramp\tramp-vc.el.~1~ c:\progra~1\xemacs\xemacs-packages\lisp\tramp\tramp-vc.el --- c:\progra~1\xemacs\xemacs-packages\lisp\tramp\tramp-vc.el.~1~ 2007-08-19 15:00:12.718750000 +0200 +++ c:\progra~1\xemacs\xemacs-packages\lisp\tramp\tramp-vc.el 2007-08-19 15:00:12.718750000 +0200 ＠＠ -453,7 +453,7 ＠＠ (tramp-tramp-file-p file) ; tramp file (setq ad-return-value (save-match-data - (tramp-handle-vc-user-login-name uid)))) ; get the owner name + (tramp-handle-vc-user-login-name)))) ; get the owner name ad-do-it))) ; else call the original (add-hook 'tramp-unload-hook For easypg, following advice was suggested by Daiki and slightly modified by me. It does not work first time accessing a .gpg file via C-x v ~ (vc-version-other-window) I have to M-x load RET vc RET first. Haven't investigated that yet. ; As suggested in http://article.gmane.org/gmane.emacs.gnus.general/64742 ; From: Daiki Ueno <ueno <at> unixuser.org> ; Subject: Re: EasyPG 0.0.12 ; Newsgroups: gmane.emacs.gnus.general ; Date: 2007-05-30 08:30:27 GMT (2 hours and 45 minutes ago) ; ; >>>>> In <loom.20070530T090846-624 <at> post.gmane.org> ; >>>>> Adrian Aichner <adrian <at> xemacs.org> wrote: ; > Hi Daiki! ; ; > ah, inhibiting file-name-handlers might be an option, even though I ; > don't know whether it will break existing cusomizations out there. ; ; I just tried the following setting. It seems to work as you expected. ; ; (setq epa-file-name-regexp "\\.gpg\\(~\\|\\.~[.0-9]+~\\)?\\'") ; ; (defadvice vc-version-other-window ; (around inhibit-epa-file-handler) ; (let ((inhibit-file-name-handlers '(epa-file-handler)) ; (inhibit-file-name-operation 'write-region) ; (coding-system-for-write 'binary) ; (coding-system-for-read 'binary)) ; ad-do-it)) ; i 2007/06/02 16:55:58 Above exhibits eol-type lossage. ; so I come up with the below, which is closer to my original ; workaround and does not show this problem. ; i 2007/06/08 16:17:26 turns out the below only works for ; scop/unsupported/vc, because ; xemacs-packages/vc does not have `vc-find-version'. (if (fboundp ' vc-find-version) (defadvice vc-find-version (around inhibit-epa-file-handler) (let ((inhibit-file-name-handlers '(epa-file-handler)) (inhibit-file-name-operation 'write-region) (coding-system-for-write 'binary) (coding-system-for-read 'binary)) ad-do-it)) (defadvice vc-version-other-window (around inhibit-epa-file-handler) (let ((inhibit-file-name-handlers '(epa-file-handler)) (inhibit-file-name-operation 'write-region) (coding-system-for-write 'binary) (coding-system-for-read 'binary)) ad-do-it))) I'm all for it. Best regards! Adrian -- Adrian Aichner mailto:adrian＠xemacs.org http://www.xemacs.org/ _______________________________________________ XEmacs-Beta mailing list XEmacs-Beta(a)xemacs.org http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta