Re: Ben's Big Patch

Ben Wing wrote: That's really, really great. I guess it'll need a updates to a bunch of packages before Windows users and two-button-mouse X users really see the benefit. I think that's it's evil to expose the lisp programmer to system-dependent stuff unless it's absolutely necessary. In this case I don't think that it is necessary - other toolkits support standard icons (eg XmMessageBox) and I don't see that the ability to say 'abortretryignore instead of supplying the buttons manually is a big enough win to introduce a system-dependent API. A more general way of supporting the use of standard icons would be to extend the 'question dialog box to accept 'iconexclamation etc. (This would mean that you couldn't just use MessageBox() to implement this on Windows 'though). Our Xt implementation could just ignore the icons for the moment. The "genericisation" of the printer dialogs are really welcome. But I don't think you should continue to expose 'print-setup because it's deprecated ("The Print Setup dialog box should not be used in new applications") in favour of page-setup. Neither print-setup nor page-setup have analogues in other toolkits that I'm aware of and since a Windows-specific print-setup dialog isn't required we shouldn't get rid of it. Some minor things I noticed: - What is the effect of your change to package-get-dependencies? - Looks like you started to add to the 'transpose-lines documentation and forgot to finish. Jonathan. -- Jonathan Harris | jhar(a)tardis.ed.ac.uk London, England | Jonathan.Harris(a)symbian.com