Re: Review lags [was: crm.el ...]

Jan> I did just that about a year ago -- I posted a reasonably simple Jan> patch that adds about 4 lines of code to the XEmacs code base. I Jan> brought the issue up again about three weeks ago, and a couple of Jan> days ago, but it seems continuous nagging doesn't get me anywhere. Stephen> I'm sorry about that. Your patch is not one I'm competent to Stephen> review. As far as I knew, Ben was aware of it (and in fact Stephen> has since committed it), so I left it at that. Jan> I understand "being short-handed for developers", but this Jan> attitude will cause even more developers to go elsewhere. Stephen> It's not an "attitude", it's a fact. If saying so would make Stephen> developers go elsewhere, I think it's only fair to say so so Stephen> they can make an informed choice: go, or ask for the authority Stephen> to make it happen themselves. Stephen> If you want to accept the responsibility (ie, to review _some_ Stephen> of other people's small patches) and get the authority (to Stephen> commit them), write to xemacs-review(a)xemacs.org and say you Stephen> want to be a reviewer. I can't say it's a done deal, but I Stephen> know your posts and patches well enough to support you; I Stephen> suppose there are probably other reviewers who would, too. Stephen> By the way, as far as I'm concerned, people who have been Stephen> contributing for a while, even just bug reports, are welcome Stephen> to nominate themselves to the review board. It does require Stephen> that the current reviewers be able to assess your ability to Stephen> review, so you need a public track record as a developer Stephen> somewhere (preferably in XEmacs, of course) or a strong Stephen> sponsor already on the board. Well, I don't feel competent enough to review code or to deeply participate in development. I make small changes and fixes which really need reviewing by more knowledgeable people. Hence, I believe my role isn't to review, but to submit patches and report bugs. --J.