Looks good to me, but I don't have a way to test it (I've never
bothered to get the sound working on my current Linux boxen).
One question: is "wait" the right word? Ie, does XEmacs stop
responding if the sound is still playing? If so, maybe this isn't the
right way to fix it. If not, we should fix the comment.
One little nit: in
+ /* wait for it to finish -- added by HST to fix killing the thing
+ before it's actually played much if anything */
you shouldn't "sign" it unless you think there's a good reason to
suppose you know more about this than anybody else will *and* you want
to invite queries about it. Information about bugs being fixed should
be in the ChangeLog/hg log (and the email, of course!) It's usually
not needed in the code.
Steve
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta