Re: [PATCH] Last assault on binary-process-output
Some time ago, Hrvoje Niksic wrote...
The purpose of NEWS is to document user-visible changes. If I have
code that does:
(let ((binary-process-output t))
...)
and that code no longer works in 21.2, this should well be mentioned
in NEWS, under "Lisp and internal changes". The entry might look like
this:
** The variable `binary-process-output' is now obsolete. This
variable was previously used to tell NT XEmacs to forgo the CRLF
detection and accept its input as binary. The correct way to do it is
now the same as under Unix, by binding `coding-system-for-read'.
The NT-specific code that looked like this:
(let ((binary-process-output t))
... code ...)
should be changed to this:
(let ((coding-system-for-read 'binary))
... code ...)
That's the excellent entry, thanks Hrvoje. One correction, I am going to
remove this variable by release time, not obsolete it. There is another
on, binary-process-input, declared in C code, but doing really nothing.
Should we document its extinction? Or just pretend it has never been there?
Big K