Re: [PATCH] fix eol handlling in propagated glyphs.
>>>> "Andy" == Andy Piper <andyp(a)bea.com>
writes:
Andy> At 01:12 PM 4/24/2002 -0400, Charles Hines wrote:
> Alrighty...doing that now...hm, I didn't try it with VM yet,
but I see no
> change in the behavior of my revamped simple testcase that mimics
> it...trying VM now...yup, no change in the behavior (i.e. spaces between
> the strips are still present in both VM and 'example-2' in my revamped
> testcase that I included in my earlier email).
Andy> Ok, but in the case that you add the extent to a line *only* containing
Andy> "\n" rather than " \n" you should see a difference. I agree
that
Andy> wrapping is the correct behavior if there is more text to display (a
Andy> space in this instance).
Right.
> But then, as I said earlier, I'm still not sure that this new
behavior is
> actually an XEmacs redisplay bug. I mean, what if you had an extent that
> had a small begin glyph but a lot of text in the extent and this text went
> past the end of the screen, you'd expect that to wrap, correct? Assuming
Andy> It won't right now, I thought that implementing this was too big a
Andy> behavior change - since it would cause images to wrap also. Making them
Andy> wrap is not hard.
I hope you didn't misinterpret my meaning there: I was talking about the text
wrapping only, not the glyph (i.e. glyph goes offscreen but the text that
would be drawn offscreen wraps). I don't think that the glyph should wrap
(that'd look pretty wierd for most images I think, especially in VM where it's
doing large images in strips) but I'd expect the text to do so (as it now
does).
> truncate-lines was set appropriately of course. I see no
difference here -
> the text in the extent is going beyond the end of the screen so it *should*
> wrap, no?
Andy> Right. It seems to me the most important case is that we don't just drop
Andy> text because it is inside an extent - it is the glyph we are clipping
Andy> not the extent itself.
Right, and that seems to be what your first patch fixed to be "correct" (as I
said I saw no behavioral change with that last patch you sent so that had the
same "correct" behavior).
So Kyle, do you have a special reason for including that space in the extent?
If not, would you mind removing it from the extent for the next version of VM?
Thanks,
Chuck
--
Charles K. Hines <ckh(a)requesttech.com> <chuck.hines(a)baesystems.com>
Principal Scientist at ReQuest Technologies Inc (http://www.ReQuestTech.com/)
"You tell him and I will smack you. I will smack you like a
bad bad donkey, okay!" - Pepe in 'Muppets From Space'