>>>> "vin" == Vin Shelton <acs(a)xemacs.org>
writes:
vin> On my Solaris 5.8 machines here at work, when running 'make
vin> TAGS' with a 21.4.16 build, I'm getting a segv running etags.
vin> So, I set external_to_internal_register to 0 and the crash
vin> went away.
That looks right. In XEmacs proper, the patbuf is taken from a static
cache, so it will be initialized to all zeros. I forgot about etags
when I synched this from 21.4 to 21.5. :-(
vin> But, this can't be right, can it? patbuf is allocated in
vin> etags.c and it looks like it's not fully initialized, but if
vin> this fix is right, how could the code ever have worked?
In 21.4 etags.c, this is quite recently added code (post 21.4.15; to
fix the shy groups bug); maybe nobody's actually used etags.c with it.
In 21.5 etags.c, the whole pattern is explicitly cleared by setting it
to zeropattern.
--
Institute of Policy and Planning Sciences
http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.