Re: NAS related source code error?

OK. Would this patch be any better: http://www.xemacs.org/list-archives/xemacs-patches/200006/msg00005.html Please advise. - vin vin> Thank you for this patch. It has been applied to the 21.1 vin> branch of XEmacs and will appear in XEmacs 21.1.12. Stephen> NOOOOOOoooooooo! (That's not a veto, I'm not on -review.) Edwin> Problem: LITTLE_ENDIAN is not defined in "src/nas.c". Stephen> Sure it is, in <audio/fileutil.h>, NAS 1.2p5. Edwin> Resolution: The NAS include files define Edwin> "NAS_LITTLE_ENDIAN" and "NAS_BIG_ENDIAN", not Edwin> "LITTLE_ENDIAN" and "BIG_ENDIAN". Stephen> Not in 1.2p5. Those headers define only "LITTLE_ENDIAN" and Stephen> "BIG_ENDIAN". Edwin> Fix: Changed "src/nas.c" to use "NAS_*". Stephen> Breaking all systems with 1.2p5 or earlier installed. This is true of Stephen> Debian Linux (woody), for example. Stephen> Please revert this patch and figure out how to do it without breaking Stephen> older systems. This can be easily done with Stephen> #ifndef NAS_BIG_ENDIAN Stephen> #define NAS_BIG_ENDIAN BIG_ENDIAN Stephen> #endif Stephen> etc after the #includes, but it is probably preferable to fix it so Stephen> that modern NAS installations don't have to suffer with the #undef Stephen> BIG_ENDIAN breakage. I don't see how to do that simply in the source, Stephen> you'll probably have to do it via configure. Stephen> -- Stephen> University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Stephen> Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091 Stephen> _________________ _________________ _________________ _________________ Stephen> What are those straight lines for? "XEmacs rules."