Re: [PATCH] generalizing face settings..., GTK face fixes
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
>>>>> "-BP" == William M Perry
<wmperry(a)gnu.org> writes:
-BP> The face settings in lisp/faces.el and a few other places
-BP> used window-system specific specifications instead of using
-BP> the generic 'win' type. This patch changes things like:
Yes. There was a comment about "why don't we use 'win instead of the
specific windowing systems?" too, IIRC.
I think I put that in during the GTK port, at least somewhere in C land.
Do you know why they didn't in the first place, or otherwise are
you
willing to promise that this won't ever hurt anybody anywhere? ;-)
No clue why they didn't do it in the first place. Might originally have
been envisioning different defaults for windows and X11, but everywhere I
saw these, the specs for (x) vs (mswindows) vs (gtk) were identical.
The only danger I see is someone porting to a windowing system that doesn't
have named colors, or sufficiently different named colors that 'red3'
doesn't work. This could be fixed by simply adding more specs with generic
colors in them. Most already do (highlight is 'darkseagreen2' 'green'),
the noticeable exceptions seem to be text-cursor, list-mode-item-selected,
primary-selection, and gui-button-face.
I could add those and resubmit the patch if you wish. Basically would be:
text-cursor - add red
list-mode-item-selected - gray
primary-selection - gray
gui-button-face - gray
Unless anybody has objections to falling back to just 'gray' instead of
various shades of it....
-bp
--
Ceterum censeo vi esse delendam