Re: Pushing new vc towards regular packages tree
Ville Skyttä <scop(a)xemacs.org> writes:
Hi,
> For tramp I had to apply following quick patch but the issue
needs to
> be investigated further.
>
> Why is following patch not necessary with the latest official vc
> package?
The patch is OK. `uid' is not known inside the advice, and it is an
optional parameter to `tramp-handle-vc-user-login-name'. I'll apply it
in Tramp CVS. Somebody else might sync it with the XEmacs Tramp
repository (I've stalled myself, you know).
Can't say for certain offhand, but comments slightly above the
line you
patched include:
;; The following defadvice is no longer necessary after changes in VC
;; on 2006-01-25, Andre.
[...]
;; With Emacs 22, the definition of `vc-user-login-name' has been
;; changed. It doesn't need to be adviced any longer.
...so I suppose the whole (defadvice vc-user-login-name) no longer applies to
the new vc.
Yes, indeed.
If it's not needed, perhaps there's a way to detect it and
skip the
code altogether? There's already a (unless (fboundp 'process-file))
around it, but perhaps that's for some other purpose?
(fboundp 'process-file) is a check for "GNU Emacs 22 existence", because
it is a new function introduced there. Implicitely, it means "new vc
existence". If there is a better check for the existence of "new vc", we
should apply that instead.
Btw, it would be nice if XEmacs could introduce the new functions
`process-file` and `start-file-process'. They are file name handler
based counterparts of `call-process' and `start-process', allowing to
run processes on remote machines. At least `process-file' is used in
vc.el of GNU Emacs 22.
Best regards, Michael.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta