Hi Stephen,
Thanks for writing this code to integrate the Guided Tour.
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
Please check the following points:
1. Use of your name. Tastes differ, and you may want more or less
credits. I wish to respect your tastes. :-)
I think it sounds odd to preface most instances of "Guided Tour" with
"Phil
Sung's". I've attached a patch that removes some of them. :)
2. Check the comments about permissions in the ChangeLog. If you
have qualms about it, let me know.
From the ChangeLog:
Note: Phil graciously licensed these to XEmacs under the MIT/X11
license
allowing us to use *these versions only* in any way we might want to inside
of XEmacs (specifically, we can freely use this content in our Texinfo
manuals), but asks that we distribute only under the GPL or GFDL or both. The
content is copyright- assigned to the FSF, and is publicly licensed only
under the GPL and GFDL (as of this writing). When in doubt as to the intent
of the permissions for use of content, ask Phil first, don't rely on the
letter of the law or licenses.
That's perfectly fine. I think as long as it is clear that the present versions
may be used under the MIT/X11 license (and therefore can be integrated into the
Texinfo manuals), and future improvements are GPL|GFDL only, there should be
little ambiguity. Perhaps that last caveat is not necessary.
What's the plan with respect to picking up future versions? Are you going to
keep the X11-licensed version around and import future GPL|GFDL versions
alongside it? I suppose that does not have to be thought about right now.
3. Check the permissions notice in the function
`guided-tour-about'
in the Lisp. (It's the last thing in this message.) Let me know
if that expresses your intent.
It looks great.
You can install the package under GNU Emacs, but the auto-menu
installation and auto-location of data probably won't work. I'd be
curious if the rest works, but you may need to do some banging. Note
that I do have an assignment for XEmacs on file, so you can submit
code based on this code to GNU Emacs (after checking with rms) without
any legal problems that I know of.
I will play around with GNU Emacs integration when I get a chance.
For what it's worth, the HTML version has been picked up by
gnu.org:
<
http://www.gnu.org/software/emacs/tour/>
Again, thanks for packaging all this up.
Cheers,
Phil
------
*** /home/phil/src/guided-tour-xemacs/lisp/guided-tour/guided-tour.el 2007-05-03
04:21:09.000000000 -0400
--- /tmp/buffer-content-4834T3x 2007-05-03 17:26:58.000000000 -0400
***************
*** 23,29 ****
;; Variables
! (defgroup guided-tour nil "Phil Sung's Emacs Guided Tour")
(defcustom guided-tour-odp-viewer "ooimpress"
"Path to program able to view Open Document Format presentations.
--- 23,29 ----
;; Variables
! (defgroup guided-tour nil "The Emacs Guided Tour")
(defcustom guided-tour-odp-viewer "ooimpress"
"Path to program able to view Open Document Format presentations.
***************
*** 51,57 ****
["Guided Tour, Part %_2 (PDF)" guided-tour-pdf-2]
["Guided Tour, Part %_3 (PDF)" guided-tour-pdf-3]
["About COPYING the Tour" guided-tour-about])
! "The submenu for Phil Sung's \"Guided Tour of Emacs\".")
(defvar guided-tour-insinuate-menubar nil
"If non-nil, inhibits insinuation of the menubar.
--- 51,57 ----
["Guided Tour, Part %_2 (PDF)" guided-tour-pdf-2]
["Guided Tour, Part %_3 (PDF)" guided-tour-pdf-3]
["About COPYING the Tour" guided-tour-about])
! "The submenu for the \"Guided Tour of Emacs\".")
(defvar guided-tour-insinuate-menubar nil
"If non-nil, inhibits insinuation of the menubar.
***************
*** 81,87 ****
;;;###autoload
(defun guided-tour-insinuate-menubar ()
! "Add Phil Sung's Guided Tour of Emacs to the default menubar."
(unless guided-tour-insinuate-menubar
(setq guided-tour-insinuate-menubar t)
(let* ((help (guided-tour-find-menubar-help-menu)))
--- 81,87 ----
;;;###autoload
(defun guided-tour-insinuate-menubar ()
! "Add the Guided Tour of Emacs to the default menubar."
(unless guided-tour-insinuate-menubar
(setq guided-tour-insinuate-menubar t)
(let* ((help (guided-tour-find-menubar-help-menu)))
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta