Re: font-menu-ignore-scaled-fonts in 21.1. and 21.2

Jan> Andreas Jaeger <aj(a)suse.de&gt; writes: Jan> Did he explicitly set that? Why? Note that the default differs in 21.2 Jan> and 21.1. Jan> Because of Jan> 1998-08-26 Jan Vroonhof <vroonhof(a)math.ethz.ch&gt; Jan> * menubar-items.el (default-menubar): Remove "Font Weight" Jan> option, there is currently no custom equivalent.. Customize-faces Jan> is "Edit faces". Jan> However I guess I was a bit too overzealous. Jan> This problem is actually a FAQ om comp.emacs.xemacs. Because I didn't Jan> see the problem when I last looked, we've just told people to set Jan> font-menu-ignore-scaled-fonts to nil as a work around. However, now Jan> that I look at it again, it is extremely trivial. I forgot the part that Jan> checked whether the size was actually available unscaled. Jan> It should be Jan> (if (and (not (member size (aref entry 2))) Jan> font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) Jan> (disable-menu-item item) Jan> (enable-menu-item item)) Jan> This whole disabling thing needs a rethink anyway, since it can make Jan> it impossible to get from one family-size-weight combination to Jan> another if there is not of fonts with hamming distance 1 between them. Are you propossing the appended patch for 21.1.9? I'd like to see this fixed. Andreas Index: x-font-menu.el =================================================================== RCS file: /usr/CVSroot/XEmacs/xemacs-20/lisp/x-font-menu.el,v retrieving revision 1.5 diff -u -r1.5 x-font-menu.el --- x-font-menu.el 1999/05/13 12:19:37 1.5 +++ x-font-menu.el 2000/01/31 15:59:34 ＠＠ -445,15 +445,10 ＠＠ ;; The user can no longer easily control the weight using the menu ;; Note it is silly anyway as it could very well be that the font ;; has no common size+weight combinations with the default font. -;; (if (and (member weight (aref entry 1)) -;; (or (member size (aref entry 2)) -;; (and (not font-menu-ignore-scaled-fonts) -;; (member 0 (aref entry 2))))) -;; (enable-menu-item item) -;; (disable-menu-item item)) - (if (and font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) + (if (and (not (member size (aref entry 2))) + font-menu-ignore-scaled-fonts (member 0 (aref entry 2))) (disable-menu-item item) - (enable-menu-item item)) + (enable-menu-item item)) (if (string-equal family f) (select-toggle-menu-item item) (deselect-toggle-menu-item item)) -- Andreas Jaeger SuSE Labs aj(a)suse.de private aj(a)arthur.rhein-neckar.de