This looks right to me Adrian. This is why we need you committing - so
someone can test the patches before applying them :)
andy
At 03:17 AM 12/8/99 +0100, Adrian Aichner wrote:
>>>>> "APA" == Adrian Aichner
<aichner(a)ecf.teradyne.com> writes:
APA> Looks like something is wrong with the latest change to
APA> ../src/s/windowsnt.h
APA> I am investigating
Could someone please review following patch.
It fixes ../src/s/windowsnt.h breakage introduced in an attempt to
support 'Vdirectory_sep_char' under Windows NT.
Mike, could you please verify this patch work for you when you change
'Vdirectory_sep_char'?
I am building Windows NT native with GUNG_HO.
I'll submit it formally when I get positive feedback.
Best regards,
Adrian
cd d:\tmp\21.2\xemacs\
cvs diff
Compilation started at Wed Dec 08 03:00:17 1999 +0100 (W. Europe Standard
Time)
Index: src/lisp.h
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/lisp.h,v
retrieving revision 1.38.2.35
diff -u -r1.38.2.35 lisp.h
--- lisp.h 1999/12/07 06:27:17 1.38.2.35
+++ lisp.h 1999/12/08 02:02:59
@@ -2887,7 +2887,8 @@
extern Lisp_Object Vconsole_list, Vcontrolling_terminal;
extern Lisp_Object Vcurrent_compiled_function_annotation,
Vcurrent_load_list;
extern Lisp_Object Vcurrent_mouse_event, Vcurrent_prefix_arg,
Vdata_directory;
-extern Lisp_Object Vdisabled_command_hook, Vdoc_directory,
Vinternal_doc_file_name;
+extern Lisp_Object Vdirectory_sep_char, Vdisabled_command_hook;
+extern Lisp_Object Vdoc_directory, Vinternal_doc_file_name;
extern Lisp_Object Vecho_area_buffer, Vemacs_major_version;
extern Lisp_Object Vemacs_minor_version, Vexec_directory, Vexec_path;
extern Lisp_Object Vexecuting_macro, Vfeatures, Vfile_domain;
cvs server: Diffing src/m
cvs server: Diffing src/s
Index: src/s/windowsnt.h
===================================================================
RCS file: /usr/CVSroot/XEmacs/xemacs/src/s/windowsnt.h,v
retrieving revision 1.15.2.6
diff -u -r1.15.2.6 windowsnt.h
--- windowsnt.h 1999/12/07 16:45:13 1.15.2.6
+++ windowsnt.h 1999/12/08 02:03:03
@@ -125,8 +125,7 @@
/* XEmacs file I/O for DOS text files requires FILE_CODING */
#define FILE_CODING
-extern Lisp_Object Vdirectory_sep_char;
-#define DIRECTORY_SEP ((char)XCHARVAL(Vdirectory_sep_char))
+#define DIRECTORY_SEP XCHAR(Vdirectory_sep_char)
/* Define this to be the separator between devices and paths */
#define DEVICE_SEP ':'
cvs server: Diffing tests
cvs server: Diffing tests/DLL
cvs server: Diffing tests/Dnd
cvs server: Diffing tests/automated
cvs server: Diffing tests/mule
cvs server: Diffing tests/tooltalk
Compilation exited abnormally with code 1 at Wed Dec 08 03:03:22
APA> .\../src/s/windowsnt.h(128) : error C2061: syntax error :
identifier
'Vdirectory_sep_char'
APA> .\../src/s/windowsnt.h(128) : error C2059: syntax error :
';'
APA> NMAKE : fatal error U1077: 'cl' : return code '0x2'
APA> Stop.
APA> Compilation exited abnormally with code 2 at Tue Dec 07 23:57:22
--------------------------------------------------------------
Dr Andy Piper
Senior Consultant Architect, BEA Systems Ltd