On Sun, 2002-10-20 at 12:32, Glynn Clements wrote:
[Moved from xemacs-patches to xemacs-beta; that's the correct
protocol, right?]
Right, thanks :)
> When using this image-mode.el, starting up XEmacs spits out
messages to
> the console like these:
> Loading image-mode...
> Loading image-mode...done
> I wonder if this could be avoided somehow?
I don't know; I have no idea why it would do this if other modes don't.
Anybody?
> The new mode breaks XEmacs 21.1.14. This is because there are
> references to (at least these) functions you've removed in the new mode
> in lisp/format.el: image-decode-jpeg, image-decode-gif,
> image-decode-png, image-decode-xpm, image-decode-tiff,
> image-decode-tiff. As Stephen already noted, these have been removed in
> newer XEmacsen. Some `define-obsolete-function-alias'es or wrappers to
> `image-decode' would be needed, since packages need to work with XEmacs
> 21.1 and newer at the moment.
I can put those functions back in, although I have no idea whether it
will work correctly (presumably image-decode would end up being called
twice; once via format-alist, and once from image-mode).
A better fix might be for image-mode-install to just remove the
entries from format-alist; IIRC, the consensus was that they shouldn't
have been there in the first place.
Yep, that's how I've understood the consensus too. But removing stuff
from format-alist sounds a bit scary to me; that might cause problems
eg. if we later for some reason decide to put the entries back there.
How about if the old defuns were put back into image-mode, but as dummy
`make-obsolete'd ones that don't do anything? Would that work?
--
\/ille Skyttä
scop at
xemacs.org