>>>> "Stefan" == Stefan Monnier
<monnier+lists.xemacs.patches/news/(a)rum.cs.yale.edu> writes:
>>>> "Stefan" == Stefan Kamphausen
<kamphausen(a)novelscience.com> writes:
> This patch adds ruby support to the add-change-log-entry
> function by inserting the (hopefully) correct function and
> classname in parens. This just uses almost the same code as
> the func-menu does (which I sent some time ago).
Stefan> Shouldn't this be in ruby-mode.el (by setting
Stefan> add-log-current-defun-function appropriately) ?
Yes.
In this case, it doesn't matter all that much, since add-log is in the
xemacs-base package anyway. But if it were font-lock, or something
else that lives in core, I'd veto application to 21.4.
Also, if it uses almost the same code as func-menu, you should
consider making it use identical code, and having to maintain it in
only one place when your hopes are dashed and you have to patch it.
--
Institute of Policy and Planning Sciences
http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.