6:49 p.m.
Please describe as succinctly as possible:
- What happened.
- What you thought should have happened.
- Precisely what you were doing at the time.
Please also include any C or lisp back-traces that you may have.
================================================================
Dear Bug Team!
Adrian suggested to move this discussion back from xemacs-patches to
xemacs-beta:
The problem: The menu-entry: Edit->Bookmarks->Jump-to-Bookmark does
not automagically load the default bookmark file (at least in my
21.1.14). To see this do:
- create a bookmarks-file: ~/.emacs.bmk
- start xemacs: $xemacs -q
=> Edit->Bookmarks->Jump-to-Bookmark is not active
(only after doing: Edit->Bookmarks->Load-a-bookmark-file, it will
be activated)
I consider this a bug, since the help text of bookmark-load says:
Your own personal bookmark file, `~/.emacs.bmk', is maintained
automatically by Emacs; you shouldn't need to load it explicitly.
The following patch solves this problem for me because it makes sure
the default bookmark file is loaded every time one accesses the
menu-entry Edit->Bookmarks:
----------------------------------------------------------------------
--- menubar-items.orig Thu Aug 3 03:59:07 2000
+++ menubar-items.el Sat Mar 2 22:50:50 2002
＠＠ -989,6 +989,8 ＠＠
;;; The Bookmarks menu
(defun bookmark-menu-filter (&rest ignore)
+ (require 'bookmark)
+ (bookmark-maybe-load-default-file)
(let ((definedp (and (boundp 'bookmark-alist)
bookmark-alist
t)))
----------------------------------------------------------------------
However, the patch assumes that bookmarks.el is installed. Therefore,
I think the
(require 'bookmark)
statement should be replaces by something more sophisticated. I see
two possibilities:
(a)
(if (featurep 'bookmark)
(progn
(require 'bookmark)
(bookmark-maybe-load-default-file)))
(b)
(if (fboundp 'bookmark-maybe-load-default-file)
(bookmark-maybe-load-default-file))
And giving the function bookmark-maybe-load-default-file in
bookmark.el an autoload cookie...
Any suggestions?
Volker
================================================================
System Info to help track down your bug:
---------------------------------------
uname -a: Linux kesch 2.0.36 #12 Wed Dec 29 23:08:23 MET 1999 i586 unknown
./configure
XEmacs 21.1.14 "Cuyahoga Valley" configured for `i586-pc-linux'.
Where should the build process find the source code? /usr/local/xemacs/xemacs-21.1
What installation prefix should install use? /usr/local
What operating system and machine description files should XEmacs use?
`s/linux.h' and `m/intel386.h'
What compiler should XEmacs be built with? gcc -g -O3 -Wall -Wno-switch
Should XEmacs use the GNU version of malloc? yes
(Using Doug Lea's new malloc from the GNU C Library.)
Should XEmacs use the relocating allocator for buffers? yes
What window system should XEmacs use? x11
Where do we find X Windows header files? /usr/X11/include
Where do we find X Windows libraries? /usr/X11/lib
Compiling in support for XAUTH.
Compiling in support for XPM images.
Compiling in support for PNG image handling.
Compiling in support for (builtin) GIF image handling.
Compiling in support for JPEG image handling.
Compiling in support for TIFF image handling.
Compiling in native sound support.
Compiling in support for Berkeley DB.
Compiling in support for GNU DBM.
Compiling in support for ncurses.
Compiling in support for GPM (General Purpose Mouse).
Compiling in support for proper session-management.
Using Lucid menubars.
Using Lucid scrollbars.
Using Athena dialog boxes.
Compiling in DLL support.
movemail will use "dot-locking" for locking mail spool files.
Using Lisp_Objects with minimal tagbits.
Load-Path Lisp Shadows:
----------------------
(/home/vf/.xemacs/lisp/power-macros
/usr/local/lib/xemacs/xemacs-packages/lisp/edit-utils/power-macros
/home/vf/.xemacs/lisp/iswitchb
/usr/local/lib/xemacs/xemacs-packages/lisp/edit-utils/iswitchb
/home/vf/.xemacs/lisp/flyspell
/usr/local/lib/xemacs/xemacs-packages/lisp/text-modes/flyspell
/usr/local/lib/xemacs/xemacs-packages/lisp/xemacs-base/xpm-button
/usr/local/lib/xemacs-21.1.14/lisp/xpm-button)
Installed XEmacs Packages:
-------------------------
((zenirc:version 1.13 :type regular)
(xemacs-devel :version 1.4 :type single-file)
(xemacs-base :version 1.58 :type regular)
(w3 :version 1.21 :type regular)
(vm :version 7.02 :type regular)
(view-process :version 1.11 :type regular)
(vhdl :version 1.15 :type regular)
(vc :version 1.3 :type regular)
(tramp :version 1.02 :type regular)
(tm :version 1.3 :type regular)
(time :version 1.11 :type regular)
(textools :version 1.12 :type regular)
(text-modes :version 1.37 :type single-file)
(texinfo :version 1.2 :type regular)
(supercite :version 1.19 :type regular)
(strokes :version 1.08 :type regular)
(speedbar :version 1.22 :type regular)
(sounds-wav :version 1.1 :type regular)
(sounds-au :version 1.1 :type regular)
(slider :version 1.13 :type regular)
(sh-script :version 1.13 :type regular)
(sgml :version 1.08 :type regular)
(reftex :version 1.24 :type regular)
(psgml :version 1.26 :type regular)
(ps-print :version 1.02 :type regular)
(prog-modes
:version
1
.49
:type
single-file)
(pcomplete :version 1.01 :type regular)
(pcl-cvs :version 1.58 :type regular)
(pc :version 1.21 :type single-file)
(os-utils :version 1.26 :type single-file)
(net-utils :version 1.23 :type single-file)
(misc-games :version 1.15 :type single-file)
(mew :version 1.16 :type regular)
(mailcrypt :version 2.11 :type regular)
(mail-lib :version 1.43 :type regular)
(jde :version 1.32 :type regular)
(ispell :version 1.24 :type regular)
(ilisp :version 1.2 :type regular)
(igrep :version 1.08 :type regular)
(idlwave :version 1.24 :type regular)
(hm--html-menus :version 1.17 :type regular)
(gnus :version 1.58 :type regular)
(gnats :version 1.13 :type regular)
(games :version 1.13 :type regular)
(fsf-compat :version 1.1 :type single-file)
(frame-icon :version 1.09 :type regular)
(forms :version 1.14 :type regular)
(footnote :version 1.13 :type regular)
(eudc :version 1.35 :type regular)
(eterm :version 1.13 :type regular)
(eshell :version 1.02 :type regular)
(emerge :version 1.09 :type regular)
(elib :version 1.1 :type single-file)
(efs :version 1.27 :type regular)
(edit-utils :version 1.76 :type single-file)
(ediff :version 1.35 :type regular)
(edebug :version 1.14 :type regular)
(dired :version 1.11 :type regular)
(debug :version 1.14 :type regular)
(crisp :version 1.12 :type regular)
(cookie :version 1.13 :type regular)
(cc-mode :version 1.27 :type regular)
(calendar :version 1.18 :type regular)
(calc :version 1.18 :type regular)
(c-support :version 1.16 :type single-file)
(bbdb :version 1.17 :type regular)
(auctex :version 1.29 :type regular)
(apel :version 1.2 :type regular))
Features:
--------
(mail-abbrevs xemacsbug shadow sendmail rfc822 efs-cu annotations
xpm-button bookmark pp zenirc-autoloads xemacs-devel-autoloads
xemacs-base-autoloads w3-autoloads vm-autoloads view-process-autoloads
vhdl-autoloads vc-autoloads tramp-autoloads tm-autoloads
time-autoloads textools-autoloads text-modes-autoloads
texinfo-autoloads supercite-autoloads strokes-autoloads
speedbar-autoloads sounds-wav-autoloads sounds-au-autoloads
slider-autoloads sh-script-autoloads sgml-autoloads reftex-autoloads
psgml-autoloads ps-print-autoloads prog-modes-autoloads
pcomplete-autoloads pcl-cvs-autoloads pc-autoloads os-utils-autoloads
net-utils-autoloads misc-games-autoloads mew-autoloads
mailcrypt-autoloads mail-lib-autoloads jde-autoloads ispell-autoloads
ilisp-autoloads igrep-autoloads idlwave-autoloads
hm--html-menus-autoloads gnus-autoloads gnats-autoloads
games-autoloads fsf-compat-autoloads frame-icon-autoloads
forms-autoloads footnote-autoloads eudc-autoloads eterm-autoloads
eshell-autoloads emerge-autoloads elib-autoloads efs-autoloads
edit-utils-autoloads ediff-autoloads edebug-autoloads dired-autoloads
debug-autoloads crisp-autoloads cookie-autoloads cc-mode-autoloads
calendar-autoloads calc-autoloads c-support-autoloads bbdb-autoloads
auctex-autoloads apel-autoloads Standard-autoloads loadhist auto-show
fontl-hooks x-iso8859-1 menubar-items x-menubar mouse mode-motion
itimer auto-save lisp-mode easymenu iso8859-1 page buff-menu
lib-complete help-nomule derived frame text-props cus-start custom
widget cl-extra mini-cl cl cl-19 packages backquote very-early-lisp
lucid-scrollbars cut-buffer lucid-menubars athena-dialogs x tty-frames
tty toolbar native-sound scrollbar unix-processes multicast
network-streams subprocesses menubar berkeley-db dbm md5 xemacs tiff
png gif jpeg xpm lisp-float-type linux dialog devices window-system
c-balloon-help)
Recent keystrokes:
-----------------
misc-user RET misc-user
Recent messages (most recent first):
-----------------------------------
Parsing /home/vf/.mailrc...
Loading xemacsbug...done
Loading xemacsbug...
Loading bookmarks from /home/vf/.emacs.bmk...done
Loading efs-cu...done
Loading efs-cu...
Loading bookmarks from /home/vf/.emacs.bmk...
Loading annotations...done
Loading annotations...
Loading xpm-button...done
Loading xpm-button...
Loading bookmark...done
Loading bookmark...
8:32 p.m.
>>>> "Volker" == Volker Franz
<volker.franz(a)tuebingen.mpg.de> writes:
Volker> Please describe as succinctly as possible:
Volker> - What happened.
Volker> - What you thought should have happened.
Volker> - Precisely what you were doing at the time.
Volker> Please also include any C or lisp back-traces that you may have.
Volker> ================================================================
Volker> Dear Bug Team!
Volker> Adrian suggested to move this discussion back from
Volker> xemacs-patches to xemacs-beta:
Volker> The problem: The menu-entry: Edit->Bookmarks->Jump-to-Bookmark does
Volker> not automagically load the default bookmark file (at least in my
Volker> 21.1.14). To see this do:
Volker> - create a bookmarks-file: ~/.emacs.bmk
Volker> - start xemacs: $xemacs -q
Volker> => Edit->Bookmarks->Jump-to-Bookmark is not active
Volker> (only after doing: Edit->Bookmarks->Load-a-bookmark-file, it
will
Volker> be activated)
I can confirm this with vanilla (emacs-version)
"XEmacs 21.4 (patch 6) \"Common Lisp (Windows [1])\" [Lucid]
(i586-pc-win32) of Tue Feb 19 2002 on D5DC120J"
I think your option (b) would be a good solution.
Best regards,
Adrian
Volker> I consider this a bug, since the help text of
Volker> bookmark-load says:
Volker> Your own personal bookmark file, `~/.emacs.bmk', is maintained
Volker> automatically by Emacs; you shouldn't need to load it explicitly.
Volker> The following patch solves this problem for me because it makes sure
Volker> the default bookmark file is loaded every time one accesses the
Volker> menu-entry Edit->Bookmarks:
Volker> ----------------------------------------------------------------------
Volker> --- menubar-items.orig Thu Aug 3 03:59:07 2000
Volker> +++ menubar-items.el Sat Mar 2 22:50:50 2002
Volker> ＠＠ -989,6 +989,8 ＠＠
Volker> ;;; The Bookmarks menu
Volker> (defun bookmark-menu-filter (&rest ignore)
Volker> + (require 'bookmark)
Volker> + (bookmark-maybe-load-default-file)
Volker> (let ((definedp (and (boundp 'bookmark-alist)
Volker> bookmark-alist
Volker> t)))
Volker> ----------------------------------------------------------------------
Volker> However, the patch assumes that bookmarks.el is installed. Therefore,
Volker> I think the
Volker> (require 'bookmark)
Volker> statement should be replaces by something more sophisticated. I see
Volker> two possibilities:
Volker> (a)
Volker> (if (featurep 'bookmark)
Volker> (progn
Volker> (require 'bookmark)
Volker> (bookmark-maybe-load-default-file)))
Volker> (b)
Volker> (if (fboundp 'bookmark-maybe-load-default-file)
Volker> (bookmark-maybe-load-default-file))
Volker> And giving the function bookmark-maybe-load-default-file in
Volker> bookmark.el an autoload cookie...
Volker> Any suggestions?
Volker> Volker
Volker> ================================================================
Volker> System Info to help track down your bug:
Volker> ---------------------------------------
Volker> uname -a: Linux kesch 2.0.36 #12 Wed Dec 29 23:08:23 MET 1999 i586 unknown
Volker> ./configure
Volker> XEmacs 21.1.14 "Cuyahoga Valley" configured for
`i586-pc-linux'.
Volker> Where should the build process find the source code?
/usr/local/xemacs/xemacs-21.1
Volker> What installation prefix should install use? /usr/local
Volker> What operating system and machine description files should XEmacs use?
Volker> `s/linux.h' and `m/intel386.h'
Volker> What compiler should XEmacs be built with? gcc -g -O3 -Wall
-Wno-switch
Volker> Should XEmacs use the GNU version of malloc? yes
Volker> (Using Doug Lea's new malloc from the GNU C Library.)
Volker> Should XEmacs use the relocating allocator for buffers? yes
Volker> What window system should XEmacs use? x11
Volker> Where do we find X Windows header files? /usr/X11/include
Volker> Where do we find X Windows libraries? /usr/X11/lib
Volker> Compiling in support for XAUTH.
Volker> Compiling in support for XPM images.
Volker> Compiling in support for PNG image handling.
Volker> Compiling in support for (builtin) GIF image handling.
Volker> Compiling in support for JPEG image handling.
Volker> Compiling in support for TIFF image handling.
Volker> Compiling in native sound support.
Volker> Compiling in support for Berkeley DB.
Volker> Compiling in support for GNU DBM.
Volker> Compiling in support for ncurses.
Volker> Compiling in support for GPM (General Purpose Mouse).
Volker> Compiling in support for proper session-management.
Volker> Using Lucid menubars.
Volker> Using Lucid scrollbars.
Volker> Using Athena dialog boxes.
Volker> Compiling in DLL support.
Volker> movemail will use "dot-locking" for locking mail spool files.
Volker> Using Lisp_Objects with minimal tagbits.
Volker> Load-Path Lisp Shadows:
Volker> ----------------------
Volker> (/home/vf/.xemacs/lisp/power-macros
Volker> /usr/local/lib/xemacs/xemacs-packages/lisp/edit-utils/power-macros
Volker> /home/vf/.xemacs/lisp/iswitchb
Volker> /usr/local/lib/xemacs/xemacs-packages/lisp/edit-utils/iswitchb
Volker> /home/vf/.xemacs/lisp/flyspell
Volker> /usr/local/lib/xemacs/xemacs-packages/lisp/text-modes/flyspell
Volker> /usr/local/lib/xemacs/xemacs-packages/lisp/xemacs-base/xpm-button
Volker> /usr/local/lib/xemacs-21.1.14/lisp/xpm-button)
Volker> Installed XEmacs Packages:
Volker> -------------------------
Volker> ((zenirc:version 1.13 :type regular)
Volker> (xemacs-devel :version 1.4 :type single-file)
Volker> (xemacs-base :version 1.58 :type regular)
Volker> (w3 :version 1.21 :type regular)
Volker> (vm :version 7.02 :type regular)
Volker> (view-process :version 1.11 :type regular)
Volker> (vhdl :version 1.15 :type regular)
Volker> (vc :version 1.3 :type regular)
Volker> (tramp :version 1.02 :type regular)
Volker> (tm :version 1.3 :type regular)
Volker> (time :version 1.11 :type regular)
Volker> (textools :version 1.12 :type regular)
Volker> (text-modes :version 1.37 :type single-file)
Volker> (texinfo :version 1.2 :type regular)
Volker> (supercite :version 1.19 :type regular)
Volker> (strokes :version 1.08 :type regular)
Volker> (speedbar :version 1.22 :type regular)
Volker> (sounds-wav :version 1.1 :type regular)
Volker> (sounds-au :version 1.1 :type regular)
Volker> (slider :version 1.13 :type regular)
Volker> (sh-script :version 1.13 :type regular)
Volker> (sgml :version 1.08 :type regular)
Volker> (reftex :version 1.24 :type regular)
Volker> (psgml :version 1.26 :type regular)
Volker> (ps-print :version 1.02 :type regular)
Volker> (prog-modes
Volker> :version
Volker> 1
Volker> .49
Volker> :type
Volker> single-file)
Volker> (pcomplete :version 1.01 :type regular)
Volker> (pcl-cvs :version 1.58 :type regular)
Volker> (pc :version 1.21 :type single-file)
Volker> (os-utils :version 1.26 :type single-file)
Volker> (net-utils :version 1.23 :type single-file)
Volker> (misc-games :version 1.15 :type single-file)
Volker> (mew :version 1.16 :type regular)
Volker> (mailcrypt :version 2.11 :type regular)
Volker> (mail-lib :version 1.43 :type regular)
Volker> (jde :version 1.32 :type regular)
Volker> (ispell :version 1.24 :type regular)
Volker> (ilisp :version 1.2 :type regular)
Volker> (igrep :version 1.08 :type regular)
Volker> (idlwave :version 1.24 :type regular)
Volker> (hm--html-menus :version 1.17 :type regular)
Volker> (gnus :version 1.58 :type regular)
Volker> (gnats :version 1.13 :type regular)
Volker> (games :version 1.13 :type regular)
Volker> (fsf-compat :version 1.1 :type single-file)
Volker> (frame-icon :version 1.09 :type regular)
Volker> (forms :version 1.14 :type regular)
Volker> (footnote :version 1.13 :type regular)
Volker> (eudc :version 1.35 :type regular)
Volker> (eterm :version 1.13 :type regular)
Volker> (eshell :version 1.02 :type regular)
Volker> (emerge :version 1.09 :type regular)
Volker> (elib :version 1.1 :type single-file)
Volker> (efs :version 1.27 :type regular)
Volker> (edit-utils :version 1.76 :type single-file)
Volker> (ediff :version 1.35 :type regular)
Volker> (edebug :version 1.14 :type regular)
Volker> (dired :version 1.11 :type regular)
Volker> (debug :version 1.14 :type regular)
Volker> (crisp :version 1.12 :type regular)
Volker> (cookie :version 1.13 :type regular)
Volker> (cc-mode :version 1.27 :type regular)
Volker> (calendar :version 1.18 :type regular)
Volker> (calc :version 1.18 :type regular)
Volker> (c-support :version 1.16 :type single-file)
Volker> (bbdb :version 1.17 :type regular)
Volker> (auctex :version 1.29 :type regular)
Volker> (apel :version 1.2 :type regular))
Volker> Features:
Volker> --------
Volker> (mail-abbrevs xemacsbug shadow sendmail rfc822 efs-cu annotations
Volker> xpm-button bookmark pp zenirc-autoloads xemacs-devel-autoloads
Volker> xemacs-base-autoloads w3-autoloads vm-autoloads view-process-autoloads
Volker> vhdl-autoloads vc-autoloads tramp-autoloads tm-autoloads
Volker> time-autoloads textools-autoloads text-modes-autoloads
Volker> texinfo-autoloads supercite-autoloads strokes-autoloads
Volker> speedbar-autoloads sounds-wav-autoloads sounds-au-autoloads
Volker> slider-autoloads sh-script-autoloads sgml-autoloads reftex-autoloads
Volker> psgml-autoloads ps-print-autoloads prog-modes-autoloads
Volker> pcomplete-autoloads pcl-cvs-autoloads pc-autoloads os-utils-autoloads
Volker> net-utils-autoloads misc-games-autoloads mew-autoloads
Volker> mailcrypt-autoloads mail-lib-autoloads jde-autoloads ispell-autoloads
Volker> ilisp-autoloads igrep-autoloads idlwave-autoloads
Volker> hm--html-menus-autoloads gnus-autoloads gnats-autoloads
Volker> games-autoloads fsf-compat-autoloads frame-icon-autoloads
Volker> forms-autoloads footnote-autoloads eudc-autoloads eterm-autoloads
Volker> eshell-autoloads emerge-autoloads elib-autoloads efs-autoloads
Volker> edit-utils-autoloads ediff-autoloads edebug-autoloads dired-autoloads
Volker> debug-autoloads crisp-autoloads cookie-autoloads cc-mode-autoloads
Volker> calendar-autoloads calc-autoloads c-support-autoloads bbdb-autoloads
Volker> auctex-autoloads apel-autoloads Standard-autoloads loadhist auto-show
Volker> fontl-hooks x-iso8859-1 menubar-items x-menubar mouse mode-motion
Volker> itimer auto-save lisp-mode easymenu iso8859-1 page buff-menu
Volker> lib-complete help-nomule derived frame text-props cus-start custom
Volker> widget cl-extra mini-cl cl cl-19 packages backquote very-early-lisp
Volker> lucid-scrollbars cut-buffer lucid-menubars athena-dialogs x tty-frames
Volker> tty toolbar native-sound scrollbar unix-processes multicast
Volker> network-streams subprocesses menubar berkeley-db dbm md5 xemacs tiff
Volker> png gif jpeg xpm lisp-float-type linux dialog devices window-system
Volker> c-balloon-help)
Volker> Recent keystrokes:
Volker> -----------------
Volker> misc-user RET misc-user
Volker> Recent messages (most recent first):
Volker> -----------------------------------
Volker> Parsing /home/vf/.mailrc...
Volker> Loading xemacsbug...done
Volker> Loading xemacsbug...
Volker> Loading bookmarks from /home/vf/.emacs.bmk...done
Volker> Loading efs-cu...done
Volker> Loading efs-cu...
Volker> Loading bookmarks from /home/vf/.emacs.bmk...
Volker> Loading annotations...done
Volker> Loading annotations...
Volker> Loading xpm-button...done
Volker> Loading xpm-button...
Volker> Loading bookmark...done
Volker> Loading bookmark...
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
2:31 a.m.
>>>> "Volker" == Volker Franz
<volker.franz(a)tuebingen.mpg.de> writes:
Volker> However, the patch assumes that bookmarks.el is
Volker> installed. Therefore, I think the
Volker> (require 'bookmark)
Volker> statement should be replaces by something more
Volker> sophisticated. I see two possibilities:
What's wrong with the third possibility? :-)
(when (require 'bookmark nil t)
(bookmark-maybe-load-default-file))
I'd be inclined to approve for 21.4 after a test on a platform where
bookmark is _not_ installed.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
7:03 a.m.
>>>> "Stephen" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
>>>> "Volker" == Volker Franz
<volker.franz(a)tuebingen.mpg.de> writes:
Volker> However, the patch
assumes that bookmarks.el is
Volker> installed. Therefore, I think the
Volker> (require 'bookmark)
Volker> statement should be replaces by something more
Volker> sophisticated. I see two possibilities:
Stephen> What's wrong with the third possibility? :-)
What's wrong with (b)?
Why not add the autoload cookie?
Stephen> (when (require 'bookmark nil t)
Stephen> (bookmark-maybe-load-default-file))
Stephen> I'd be inclined to approve for 21.4 after a test on a
Stephen> platform where bookmark is _not_ installed.
Have you put your solution thru this test?
Stephen> --
Stephen> Institute of Policy and Planning Sciences
http://turnbull.sk.tsukuba.ac.jp
Stephen> University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573
JAPAN
Stephen> Don't ask how you can "do" free software
business;
Stephen> ask what your business can "do for" free
software.
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
7:50 a.m.
>>>> "APA" == Adrian Aichner
<Adrian.Aichner(a)t-online.de> writes:
APA> What's wrong with (b)?
Nothing, except ...
APA> Why not add the autoload cookie?
... bloat. I'm not saying it _is_ bloat, but we really should not
mark internal utilities as entry points.
Stephen> I'd be inclined to approve for 21.4 after a test on a
Stephen> platform where bookmark is _not_ installed.
APA> Have you put your solution thru this test?
No. I'm not going to put any further work into this, somebody != me
will have to submit a patch. I _will_ look at _any_ solution tested
on a platform where bookmark is not installed. This happens to be the
most elegant if it works, IMHO.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
5:58 p.m.
Hi,
>>>> "SJT" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
SJT> What's wrong with the third
possibility? :-)
SJT> (when (require 'bookmark nil t)
SJT> (bookmark-maybe-load-default-file))
If I understand correctly, this:
(require 'bookmark nil t)
works only in XEmacs > 21.1.14??? (21.1.14 doesn't seem to know the
4th argument).
SJT> ... but we really
SJT> should not mark internal utilities as entry points.
Hmmm - but we donot treat it as internal utility in both cases
(because we call it from menubar-items.el), right??? Maybe the most
consistent way would be to move the function bookmark-menu-filter to
bookmark.el...???
Volker
8:17 p.m.
>>>> "Volker" == Volker Franz
<volker.franz(a)tuebingen.mpg.de> writes:
Volker> Hi,
>>>> "SJT" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
SJT> What's wrong with the third
possibility? :-)
SJT> (when (require 'bookmark nil t)
SJT> (bookmark-maybe-load-default-file))
Volker> If I understand correctly, this:
Volker> (require 'bookmark nil t)
Volker> works only in XEmacs > 21.1.14??? (21.1.14 doesn't seem to know the
Volker> 4th argument).
SJT> ... but we really
SJT> should not mark internal utilities as entry points.
Volker> Hmmm - but we donot treat it as internal utility in both
Volker> cases (because we call it from menubar-items.el), right???
Volker> Maybe the most consistent way would be to move the
Volker> function bookmark-menu-filter to bookmark.el...???
Hi Volker,
I haven't played with this, but it seems to be the best idea yet to
move bookmark-menu-filter to the bookmark package.
If this can be interfaced to cleanly in menubar-items.el, we'd have a
winner I think.
Adrian
Volker> Volker
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
5:39 p.m.
Hi Adrian and Stephen,
>>>> "APA" == Adrian Aichner
<Adrian.Aichner(a)t-online.de> writes:
APA> I haven't played with
this, but it seems to be the best idea
APA> yet to move bookmark-menu-filter to the bookmark package.
ok, I think we have a plan: I will try to move bookmark-menu-filter
cleanly to bookmark.el and get back to xemacs-beta. This might take a
while --- but don't worry, I won't forget it :-)
--
Volker
1:25 a.m.
>>>> "Volker" == Volker Franz
<volker.franz(a)tuebingen.mpg.de> writes:
Volker> (require 'bookmark nil t)
Volker> works only in XEmacs > 21.1.14??? (21.1.14 doesn't seem to
Volker> know the 4th argument).
OK, scratch that idea.
SJT> ... but we really should not mark internal utilities as entry
SJT> points.
Volker> Hmmm - but we donot treat it as internal utility in both
Volker> cases (because we call it from menubar-items.el), right???
Volker> Maybe the most consistent way would be to move the
Volker> function bookmark-menu-filter to bookmark.el...???
You're right. However, menubar-items and similar code are special
cases. What really should happen is that packages register menubar
items and callbacks; the callbacks are of course internal to the
package. We just don't have such a mechanism.
In general I don't like to advertise "maybe" functions because getting
them to do the right thing is not always obvious. This is just a
theoretical feeling though, I don't have cases to back it up.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
8298
days inactive
8301
days old
8 comments
3 participants
participants (3)
-
Adrian Aichner -
Stephen J. Turnbull -
Volker Franz