Ben Wing <ben(a)666.com> writes:
Some comments:
-- Your code to enable GPM is definitely wrong. It will fail with run-temacs, when you
start on an X device and later
connect to a TTY, etc. You need to hook into create-device-hook.
Like this?
(defun gpm-create-device-hook (device)
(if (and (not noninteractive) ; Don't want to do this in batch mode
(fboundp 'gpm-enable) ; Must have C-level GPM support
(eq system-type 'linux) ; Must be running linux
(eq (device-type device) 'tty) ; on a tty
(equal "linux" (console-tty-terminal-type ; an a linux terminal type
(device-console device))))
(gpm-minor-mode 5)))
(add-hook 'create-device-hook 'gpm-create-device-hook)
-- Your next_event callback does not honor user_p, like it should.
(Motion events are not user events.)
Fixed... I'll be sending a final patch to xemacs-beta & xemacs-patches
later tonight or tomorrow morning.
-- Replace XXX, ### and FIXME with ####.
Done as well.
>The attached patch seems to work, and was really easy to add. My
only
>question is should 'real' events get priority? Right now, gpm events get
>flushed first - will this screw up anything?
Probably the events need to get ordered properly, but this is a hassle,
and probably not worth it, esp. on TTY's where you can't have focus
problems. But put a #### comments about this.
Will do.
-bp