4:06 p.m.
Hello
I just realized that Xemacs 21.5.29 Mule does not support
cp1255 (Hebrew windows) in file coding, while GNU emacs does
:(....
Are there plans to include this feature any time soon?
Uwe Brauer
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
7:24 p.m.
Uwe Brauer writes:
Hello
I just realized that Xemacs 21.5.29 Mule does not support
cp1255 (Hebrew windows) in file coding, while GNU emacs does
:(....
Are there plans to include this feature any time soon?
Not as far as I know, but it should be easy to do. Refer to the code
for ISO 8859/8 in lisp/mule/hebrew.el and the table in
etc/unicode/unicode-consortium/CP1255.TXT.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
6:14 a.m.
Stephen J. Turnbull writes:
Uwe Brauer writes:
> Hello
>
> I just realized that Xemacs 21.5.29 Mule does not support
> cp1255 (Hebrew windows) in file coding, while GNU emacs does
> :(....
>
> Are there plans to include this feature any time soon?
Not as far as I know, but it should be easy to do. Refer to the code
for ISO 8859/8 in lisp/mule/hebrew.el and the table in
etc/unicode/unicode-consortium/CP1255.TXT.
Try this patch (completely untested, and the last hunk at old line 155
may fail due to the presence of ISO 2022 control sequences; if so just
delete everything from the "＠＠ -155,12 +290,16 ＠＠" line to the end and
the patch should apply -- this hunk isn't needed it just improves the
portability of the documentation I hope).
If you have a short, publishable, no copyright problems Hebrew
document I can use for testing that would be appreciated. A pretty
wide coverage of Hebrew characters would be good, up to about 200
characters max.
# HG changeset patch
# Parent 928cc1789177474ebc5d448b2823533b53df49fa
Add CP1255 for Uwe Brauer.
diff -r 928cc1789177 -r e2693c5ea0d2 lisp/mule/hebrew.el
--- a/lisp/mule/hebrew.el Tue Nov 08 17:10:28 2011 +0900
+++ b/lisp/mule/hebrew.el Thu Nov 24 15:09:21 2011 +0900
＠＠ -144,6 +144,141 ＠＠
mnemonic "MIME/Hbrw"))
(make-coding-system
+ 'cp1255 'fixed-width "Microsoft Code Page 1255 (Hebrew)"
+ '(unicode-map
+ (
+ (#x80 ?\u20AC) ;; EURO SIGN
+ ;; (#x81 ) ;; UNDEFINED
+ (#x82 ?\u201A) ;; SINGLE LOW-9 QUOTATION MARK
+ (#x83 ?\u0192) ;; LATIN SMALL LETTER F WITH HOOK
+ (#x84 ?\u201E) ;; DOUBLE LOW-9 QUOTATION MARK
+ (#x85 ?\u2026) ;; HORIZONTAL ELLIPSIS
+ (#x86 ?\u2020) ;; DAGGER
+ (#x87 ?\u2021) ;; DOUBLE DAGGER
+ (#x88 ?\u02C6) ;; MODIFIER LETTER CIRCUMFLEX ACCENT
+ (#x89 ?\u2030) ;; PER MILLE SIGN
+ ;; (#x8A ) ;; UNDEFINED
+ (#x8B ?\u2039) ;; SINGLE LEFT-POINTING ANGLE QUOTATION MARK
+ ;; (#x8C ) ;; UNDEFINED
+ ;; (#x8D ) ;; UNDEFINED
+ ;; (#x8E ) ;; UNDEFINED
+ ;; (#x8F ) ;; UNDEFINED
+ ;; (#x90 ) ;; UNDEFINED
+ (#x91 ?\u2018) ;; LEFT SINGLE QUOTATION MARK
+ (#x92 ?\u2019) ;; RIGHT SINGLE QUOTATION MARK
+ (#x93 ?\u201C) ;; LEFT DOUBLE QUOTATION MARK
+ (#x94 ?\u201D) ;; RIGHT DOUBLE QUOTATION MARK
+ (#x95 ?\u2022) ;; BULLET
+ (#x96 ?\u2013) ;; EN DASH
+ (#x97 ?\u2014) ;; EM DASH
+ (#x98 ?\u02DC) ;; SMALL TILDE
+ (#x99 ?\u2122) ;; TRADE MARK SIGN
+ (#x9B ?\u203A) ;; SINGLE RIGHT-POINTING ANGLE QUOTATION MARK
+ ;; (#x9C ) ;; UNDEFINED
+ ;; (#x9D ) ;; UNDEFINED
+ ;; (#x9E ) ;; UNDEFINED
+ ;; (#x9F ) ;; UNDEFINED
+ (#xA0 ?\u00A0) ;; NO-BREAK SPACE
+ (#xA1 ?\u00A1) ;; INVERTED EXCLAMATION MARK
+ (#xA2 ?\u00A2) ;; CENT SIGN
+ (#xA3 ?\u00A3) ;; POUND SIGN
+ (#xA4 ?\u20AA) ;; NEW SHEQEL SIGN
+ (#xA5 ?\u00A5) ;; YEN SIGN
+ (#xA6 ?\u00A6) ;; BROKEN BAR
+ (#xA7 ?\u00A7) ;; SECTION SIGN
+ (#xA8 ?\u00A8) ;; DIAERESIS
+ (#xA9 ?\u00A9) ;; COPYRIGHT SIGN
+ (#xAA ?\u00D7) ;; MULTIPLICATION SIGN
+ (#xAB ?\u00AB) ;; LEFT-POINTING DOUBLE ANGLE QUOTATION MARK
+ (#xAC ?\u00AC) ;; NOT SIGN
+ (#xAD ?\u00AD) ;; SOFT HYPHEN
+ (#xAE ?\u00AE) ;; REGISTERED SIGN
+ (#xAF ?\u00AF) ;; MACRON
+ (#xB0 ?\u00B0) ;; DEGREE SIGN
+ (#xB1 ?\u00B1) ;; PLUS-MINUS SIGN
+ (#xB2 ?\u00B2) ;; SUPERSCRIPT TWO
+ (#xB3 ?\u00B3) ;; SUPERSCRIPT THREE
+ (#xB4 ?\u00B4) ;; ACUTE ACCENT
+ (#xB5 ?\u00B5) ;; MICRO SIGN
+ (#xB6 ?\u00B6) ;; PILCROW SIGN
+ (#xB7 ?\u00B7) ;; MIDDLE DOT
+ (#xB8 ?\u00B8) ;; CEDILLA
+ (#xB9 ?\u00B9) ;; SUPERSCRIPT ONE
+ (#xBA ?\u00F7) ;; DIVISION SIGN
+ (#xBB ?\u00BB) ;; RIGHT-POINTING DOUBLE ANGLE QUOTATION MARK
+ (#xBC ?\u00BC) ;; VULGAR FRACTION ONE QUARTER
+ (#xBD ?\u00BD) ;; VULGAR FRACTION ONE HALF
+ (#xBE ?\u00BE) ;; VULGAR FRACTION THREE QUARTERS
+ (#xBF ?\u00BF) ;; INVERTED QUESTION MARK
+ (#xC0 ?\u05B0) ;; HEBREW POINT SHEVA
+ (#xC1 ?\u05B1) ;; HEBREW POINT HATAF SEGOL
+ (#xC2 ?\u05B2) ;; HEBREW POINT HATAF PATAH
+ (#xC3 ?\u05B3) ;; HEBREW POINT HATAF QAMATS
+ (#xC4 ?\u05B4) ;; HEBREW POINT HIRIQ
+ (#xC5 ?\u05B5) ;; HEBREW POINT TSERE
+ (#xC6 ?\u05B6) ;; HEBREW POINT SEGOL
+ (#xC7 ?\u05B7) ;; HEBREW POINT PATAH
+ (#xC8 ?\u05B8) ;; HEBREW POINT QAMATS
+ (#xC9 ?\u05B9) ;; HEBREW POINT HOLAM
+ ;; (#xCA ) ;; UNDEFINED
+ (#xCB ?\u05BB) ;; HEBREW POINT QUBUTS
+ (#xCC ?\u05BC) ;; HEBREW POINT DAGESH OR MAPIQ
+ (#xCD ?\u05BD) ;; HEBREW POINT METEG
+ (#xCE ?\u05BE) ;; HEBREW PUNCTUATION MAQAF
+ (#xCF ?\u05BF) ;; HEBREW POINT RAFE
+ (#xD0 ?\u05C0) ;; HEBREW PUNCTUATION PASEQ
+ (#xD1 ?\u05C1) ;; HEBREW POINT SHIN DOT
+ (#xD2 ?\u05C2) ;; HEBREW POINT SIN DOT
+ (#xD3 ?\u05C3) ;; HEBREW PUNCTUATION SOF PASUQ
+ (#xD4 ?\u05F0) ;; HEBREW LIGATURE YIDDISH DOUBLE VAV
+ (#xD5 ?\u05F1) ;; HEBREW LIGATURE YIDDISH VAV YOD
+ (#xD6 ?\u05F2) ;; HEBREW LIGATURE YIDDISH DOUBLE YOD
+ (#xD7 ?\u05F3) ;; HEBREW PUNCTUATION GERESH
+ (#xD8 ?\u05F4) ;; HEBREW PUNCTUATION GERSHAYIM
+ ;; (#xD9 ) ;; UNDEFINED
+ ;; (#xDA ) ;; UNDEFINED
+ ;; (#xDB ) ;; UNDEFINED
+ ;; (#xDC ) ;; UNDEFINED
+ ;; (#xDD ) ;; UNDEFINED
+ ;; (#xDE ) ;; UNDEFINED
+ ;; (#xDF ) ;; UNDEFINED
+ (#xE0 ?\u05D0) ;; HEBREW LETTER ALEF
+ (#xE1 ?\u05D1) ;; HEBREW LETTER BET
+ (#xE2 ?\u05D2) ;; HEBREW LETTER GIMEL
+ (#xE3 ?\u05D3) ;; HEBREW LETTER DALET
+ (#xE4 ?\u05D4) ;; HEBREW LETTER HE
+ (#xE5 ?\u05D5) ;; HEBREW LETTER VAV
+ (#xE6 ?\u05D6) ;; HEBREW LETTER ZAYIN
+ (#xE7 ?\u05D7) ;; HEBREW LETTER HET
+ (#xE8 ?\u05D8) ;; HEBREW LETTER TET
+ (#xE9 ?\u05D9) ;; HEBREW LETTER YOD
+ (#xEA ?\u05DA) ;; HEBREW LETTER FINAL KAF
+ (#xEB ?\u05DB) ;; HEBREW LETTER KAF
+ (#xEC ?\u05DC) ;; HEBREW LETTER LAMED
+ (#xED ?\u05DD) ;; HEBREW LETTER FINAL MEM
+ (#xEE ?\u05DE) ;; HEBREW LETTER MEM
+ (#xEF ?\u05DF) ;; HEBREW LETTER FINAL NUN
+ (#xF0 ?\u05E0) ;; HEBREW LETTER NUN
+ (#xF1 ?\u05E1) ;; HEBREW LETTER SAMEKH
+ (#xF2 ?\u05E2) ;; HEBREW LETTER AYIN
+ (#xF3 ?\u05E3) ;; HEBREW LETTER FINAL PE
+ (#xF4 ?\u05E4) ;; HEBREW LETTER PE
+ (#xF5 ?\u05E5) ;; HEBREW LETTER FINAL TSADI
+ (#xF6 ?\u05E6) ;; HEBREW LETTER TSADI
+ (#xF7 ?\u05E7) ;; HEBREW LETTER QOF
+ (#xF8 ?\u05E8) ;; HEBREW LETTER RESH
+ (#xF9 ?\u05E9) ;; HEBREW LETTER SHIN
+ (#xFA ?\u05EA) ;; HEBREW LETTER TAV
+ ;; (#xFF ) ;; UNDEFINED
+ ;; (#xFF ) ;; UNDEFINED
+ (#xFD ?\u200E) ;; LEFT-TO-RIGHT MARK
+ (#xFE ?\u200F) ;; RIGHT-TO-LEFT MARK
+ ;; (#xFF ) ;; UNDEFINED
+ )
+ mnemonic "CP1255"
+ ))
+
+(make-coding-system
'ctext-hebrew 'iso2022
"ISO-8859-8-E (Hebrew, explicit directional coding)"
'(charset-g0 ascii
＠＠ -155,12 +290,16 ＠＠
))
(set-language-info-alist
- "Hebrew" '((charset hebrew-iso8859-8)
+ "Hebrew" `((charset hebrew-iso8859-8)
(coding-system iso-8859-8)
(coding-priority iso-8859-8)
;; Not available in packages.
;; (input-method . "hebrew")
- (sample-text . "Hebrew שלום")
+ (sample-text . ,(format "Hebrew %c%c%c%c"
+ (make-char 'hebrew-iso8859-8 121)
+ (make-char 'hebrew-iso8859-8 108)
+ (make-char 'hebrew-iso8859-8 101)
+ (make-char 'hebrew-iso8859-8 109)))
(documentation . "Right-to-left writing is not yet supported.")
))
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
2:25 p.m.
> On Thu, 24 Nov 2011 15:14:24 +0900, "Stephen J.
Turnbull" <stephen(a)xemacs.org> wrote:
Stephen J. Turnbull writes:
> Uwe Brauer writes:
Try this patch (completely untested, and the last hunk at old line
155
may fail due to the presence of ISO 2022 control sequences; if so just
delete everything from the "＠＠ -155,12 +290,16 ＠＠" line to the end and
the patch should apply -- this hunk isn't needed it just improves the
portability of the documentation I hope).
Thanks very much.
If you have a short, publishable, no copyright problems Hebrew
document I can use for testing that would be appreciated. A pretty
wide coverage of Hebrew characters would be good, up to about 200
characters max.
I have I just will sort it out and see whether the coding
gets right (I am using Kile (which I usually do not use) , a
Latex editor for this)
I will send it soon.
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
7:10 p.m.
New subject: problems with your patch (was: cp1255 coding missing)
> On Thu, 24 Nov 2011 15:14:24 +0900, "Stephen J.
Turnbull" <stephen(a)xemacs.org> wrote:
Stephen J. Turnbull writes:
Try this patch (completely untested, and the last hunk at old line
155
may fail due to the presence of ISO 2022 control sequences; if so just
delete everything from the "＠＠ -155,12 +290,16 ＠＠" line to the end and
the patch should apply -- this hunk isn't needed it just improves the
portability of the documentation I hope).
First I tried to apply the whole patch. I
obtained the
following error
atch hebrew.el hebrew-diff
patching file hebrew.el
Hunk #1 succeeded at 146 with fuzz 1 (offset 2 lines).
Hunk #2 FAILED at 290.
1 out of 2 hunks FAILED -- saving rejects to file hebrew.el.rej
Then I did as you said, deleting everything from ＠＠ -155
(including this line) then the patch worked, and I could
even compile it however when I loaded the new hebrew.el
I obtain an error (trace attached)
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
7:30 a.m.
New subject: problems with your patch (was: cp1255 coding missing)
Uwe Brauer writes:
>> On Thu, 24 Nov 2011 15:14:24 +0900, "Stephen J.
Turnbull" <stephen(a)xemacs.org> wrote:
Then I did as you said, deleting everything from ＠＠ -155
(including this line) then the patch worked, and I could
even compile it
Good!
however when I loaded the new hebrew.el
I obtain an error (trace attached)
Grrrr. I forgot about that. When you make changes to coding systems,
you need to restart XEmacs, because reloading the file to redefine
existing coding systems which is not allowed.
To test just the one new coding system without restarting XEmacs, you
can use C-x C-e on the form that defines it.
Sorry for the trouble. I hope this works!
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
5:21 p.m.
New subject: problems with your patch
> On Fri, 25 Nov 2011 16:30:53 +0900, "Stephen J.
Turnbull" <stephen(a)xemacs.org> wrote:
> however when I loaded the new hebrew.el
> I obtain an error (trace attached)
Grrrr. I forgot about that. When you make changes to
coding systems, you need to restart XEmacs, because
reloading the file to redefine existing coding systems
which is not allowed.
The most obvious way does not work: I renamed the old hebrew
(el and elc file)
file in the lisp/mule directory to hebrew-org and copied the
patched versions into that directory and restarted xemacs.
When I called
set-buffer-file-coding-system
cp-1255 did not appear!
To test just the one new coding system without restarting XEmacs,
you
can use C-x C-e on the form that defines it.
You mean on the code which follows
(make-coding-system
'cp1255 'fixed-width "Microsoft Code Page 1255 (Hebrew)"
??
I did that and I obtain an error
which I attach (but most likely I misunderstood you)
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
12:31 p.m.
New subject: problems with your patch
Uwe Brauer writes:
>> On Fri, 25 Nov 2011 16:30:53 +0900, "Stephen J.
Turnbull" <stephen(a)xemacs.org> wrote:
The most obvious way does not work: I renamed the old hebrew
(el and elc file)
file in the lisp/mule directory to hebrew-org and copied the
patched versions into that directory and restarted xemacs.
I'm not sure if that should work. Probably it should, in a recent
enough XEmacs, but 21.5.29 is apparently too old. See below.
> To test just the one new coding system without restarting
XEmacs, you
> can use C-x C-e on the form that defines it.
You mean on the code which follows
(make-coding-system
'cp1255 'fixed-width "Microsoft Code Page 1255 (Hebrew)"
??
Yes, that's correct. Works for me (ie, the coding system is defined;
I don't know if it actually works on Hebrew yet, I'll try tomorrow).
I did that and I obtain an error
That's bad news for you; it means that 21.5.29 is too old to support
the modern way of defining simple coding systems like ISO 8859 and
Microsoft code pages. You'll need a more recent build of XEmacs.
In 21.5.29, you could try
M-: (define-coding-system-alias 'cp1255 'iso-8859-8) RET
which will allow you to read the Hebrew (I think), but will not be
able to decode the extra punctuation characters that CP1255 supports.
Regards,
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
2:08 p.m.
New subject: problems with your patch
> On Sun, 27 Nov 2011 21:31:28 +0900, "Stephen J.
Turnbull"
> <stephen(a)xemacs.org> wrote:
> I did that and I obtain an error
That's bad news for you; it means that 21.5.29 is too
old to support the modern way of defining simple coding
systems like ISO 8859 and Microsoft code pages. You'll
need a more recent build of XEmacs.
Now there is a problem or two.
- I am trapped in 21.5.29, because I need the xsymbol
patch you once send me (and saved my life :-D ), but
which I cannot apply to more recent versions of
21.5.X. We had a discussion about this issue some
weeks ago and Aidan admit that he changed a API which
caused the problem with xsymbol (and made your patch
necessary). He even said he wanted to un do this
change in the API, but it seems that he is now too
busy to deal with it.
- what's about all the users of older version of 21.5
or even 21.4, they will not enjoy the possibility of
cp1255 support?
In 21.5.29, you could try
M-: (define-coding-system-alias 'cp1255 'iso-8859-8)
RET
which will allow you to read the Hebrew (I think), but will not be
able to decode the extra punctuation characters that CP1255 supports.
There seems to be a different problem, but I think it is
better to open a new subject.
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
2:50 p.m.
New subject: problems with your patch
Uwe Brauer writes:
- I am trapped in 21.5.29, because I need the xsymbol
patch you once send me (and saved my life :-D ), but
which I cannot apply to more recent versions of
21.5.X.
I don't see why not. It might take some adjusting of the patch.
necessary). He even said he wanted to un do this
change in the API, but it seems that he is now too
busy to deal with it.
I'd really rather not. The API is suboptimal, but repeatedly changing
and reverting APIs for no good reason is worse. The problem should be
fixed by updating x-symbol to the new API, which I provided a patch
for.
- what's about all the users of older version of 21.5
or even 21.4, they will not enjoy the possibility of
cp1255 support?
21.4/Mule is basically deprecated at this point because it doesn't
handle Unicode well at all. Older versions of 21.5 (and 21.4, for
that matter) are not going to get patches, period: if you want
features only available in the latest version, you have to upgrade.
s for handling it as a package, the possibility is there, using CCL.
It's just a lot more tedious to do it without Aidan's 'fixed-width
coding system type. Aidan's really the only person who might know how
to do it offhand. I could learn, but it would take a fair amount of
time that I don't have right now.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
5:46 p.m.
New subject: problems with your patch
> On Mon, 28 Nov 2011 23:50:30 +0900, "Stephen J.
Turnbull" <stephen(a)xemacs.org> wrote:
Uwe Brauer writes:
> - I am trapped in 21.5.29, because I need the xsymbol
> patch you once send me (and saved my life :-D ), but
> which I cannot apply to more recent versions of
> 21.5.X.
I don't see why not. It might take some adjusting of the patch.
Before I start to discuss this patch, why can't you apply the
patch for the official and all future release?
I just downloaded 21.5.31 and used some diff utility such as
mgdiff.
The files in question seem to be: faces.el and specifier.c
I first compared 21.5.29 with and without patch and it
seemed to me in faces.el there is only a change in a doc
string while in specfier.c there are the real changes.
- the 21.5.29 to 31 changes are more difficult to
track, there are changes in faces.el which I don't
hope will influence your patch. As for specifier
There are quite some changes in specifier.c. Can you give me
a hint? If not I will try to figure it out in the coming
days myself.
> necessary). He even said he wanted to un do this
> change in the API, but it seems that he is now too
> busy to deal with it.
regards
Uwe
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
2:48 a.m.
New subject: problems with your patch
Uwe Brauer writes:
>> On Mon, 28 Nov 2011 23:50:30 +0900, "Stephen J.
Turnbull" <stephen(a)xemacs.org> wrote:
> Uwe Brauer writes:
>> - I am trapped in 21.5.29, because I need the xsymbol
>> patch you once send me (and saved my life :-D ), but
>> which I cannot apply to more recent versions of
>> 21.5.X.
> I don't see why not. It might take some adjusting of the patch.
Before I start to discuss this patch, why can't you apply the
patch for the official and all future release?
We've discussed that, repeatedly. Summary: it's the wrong thing to do
IMO; the right thing is to fix x-symbol, which is what is broken. And
it is likely to break again because the MATCHSPEC API probably needs
to be changed again anyway.
Why the patch I gave you for x-symbol didn't work for you, I still
don't know. You just gave up on it and went back to the patched core
because that worked for you. Well, it doesn't any more.
Aidan may decide he wants to revert his patch or apply mine. But if
so, he's the one to do it.
There are quite some changes in specifier.c. Can you give me
a hint? If not I will try to figure it out in the coming
days myself.
Those changes were done by Ben Wing and I'm not really sure why, so I
can't really help much with the 21.5.29 -> 31 changes.
My patch was very simple, though. I defined a function to check and
if necessary convert the MATCHSPEC argument, and then used it in
several functions (probably instead of the macro CHECK_CONS, although
I forget the details, anyway, it needs to be used instead of any
type-checking of the MATCHSPEC argument). I gather Ben changed the
signature of some functions to not use MATCHSPEC anymore; those
functions won't need the change any more.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
10:26 a.m.
New subject: problems with your patch
We've discussed that, repeatedly. Summary: it's the
wrong thing to do IMO; the right thing is to fix
x-symbol, which is what is broken. And it is likely to
break again because the MATCHSPEC API probably needs to
be changed again anyway.
Yes this is true, I had the faint hope that this time you
would say yes :-D.
Aidan may decide he wants to revert his patch or apply
mine. But if so, he's the one to do it.
ok
My patch was very simple, though. I defined a function
to check and if necessary convert the MATCHSPEC
argument, and then used it in several functions
(probably instead of the macro CHECK_CONS, although I
forget the details, anyway, it needs to be used instead
of any type-checking of the MATCHSPEC argument). I
gather Ben changed the signature of some functions to
not use MATCHSPEC anymore; those functions won't need
the change any more.
Ok I will try to merge this into the specifier.c of 21.5.31
in the coming days.
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
5088
days inactive
5095
days old
12 comments
2 participants
participants (2)
-
Stephen J. Turnbull -
Uwe Brauer