>>>> "kkm" == Kirill Katsnelson <Kirill>
writes:
kkm> Dumper should treat opaques as const until it comes to loading them,
kkm> where it to uncast unconst explicitly. This can as well go into 21.4,
kkm> as it suppresses a bunch of warnings when compiling dumper.c... Well,
kkm> a bunch of exactly two warnings, to be specific.
I don't get any warnings with gcc or sun cc.
This is a very Martinesque change - so much so, in fact, that I may
have made the same change some time ago myself, but eventually
reverted, either because of a comment by Olivier, or the fact that to
be truly const-correct and never cast away const, you should have a
pre-dump and post-dump version of the same structure, differing only
in const-ness, which would not be worth the extra confusion.
Anyways, it's clearly an improvement that dump_add_opaque's first arg
is const, and I've tested with gcc, sun cc, sun CC, so:
reviewed and approved; please commit to the trunk.