This fixes some of Ben's concerns as well as making the search dialog work (mostly) under athena. andy 2000-04-14 Andy Piper <andy(a)xemacs.org&gt; * gutter-items.el (make-search-dialog): avoid unneccessary futzing by using the new widget-callback-current-channel. (search-dialog-callback): ditto. * general.c (syms_of_general): add last-command, this-command, let and funcall. * lisp.h: declare various symbols. * glyphs.h: declare Qwidget_callback_current_channel; * glyphs-widget.c (syms_of_glyphs_widget): add Qgui_callback_current_channel. (vars_of_glyphs_widget): add Vgui_callback_current_channel. * gui-msw.c (mswindows_handle_gui_wm_command): bind widget-callback-current-channel when invoking the interactive arg. Also bind last-command and next-command when invoking the widget updates. * gui-x.c (popup_selection_callback): ditto. * gui.c (get_gui_callback): massage args so that we are always calling eval. This allows us to add our own variable bindings outside. 2000-04-06 Andy Piper <andy(a)xemacs.org&gt; * configure.in: fix typo. 2000-04-12 Andy Piper <andy(a)xemacs.org&gt; * glyphs-x.c (x_button_instantiate): use gui_items_to_widget_values since this is GC safe. (x_progress_gauge_instantiate): ditto. (x_edit_field_instantiate): ditto. (x_label_instantiate): ditto. * event-Xt.c (emacs_Xt_handle_magic_event): remove old printfs. (emacs_Xt_event_widget_focus_out): new function (emacs_Xt_event_widget_focus_in): new function. Set the keyboard focus. (emacs_Xt_event_add_widget_actions): new function. add focus functions as actions. (init_event_Xt_late): use it. 2000-04-12 Andy Piper <andy(a)xemacs.org&gt; * lwlib-Xaw.c (xaw_update_one_widget): no-op for text widgets. (xaw_update_one_value): Get strings safely. (xaw_create_text_field): add some extra properties. 2000-04-12 Andy Piper <andy(a)xemacs.org&gt; * Emacs.ad: give the gui-element face the same font as the menubar and popups. Add translations for text widgets. 2000-04-12 Andy Piper <andy(a)xemacs.org&gt; * gutter.el (default-gutter-position): moved from gutter-items.el. (default-gutter-position-changed-hook): ditto. (gutter-element-visibility-changed-hook): ditto. (set-gutter-element): ditto. (remove-gutter-element): ditto. (set-gutter-element-visible-p): ditto. (gutter-element-visible-p): ditto. (init-gutter): ditto. * dialog.el (make-dialog-box): renamed and moved from gutter-items.el * gutter-items.el: move various functions elsewhere. ------------------------------------------------------------------------ Name: wid.patch wid.patch Type: Plain Text (text/plain) Encoding: quoted-printable ------------------------------------------------------------------------ -------------------------------------------------------------- Dr Andy Piper Principal Consultant, BEA Systems Ltd

At 12:31 AM 4/15/00 -0700, Ben Wing wrote: >Text widget Btn1Down is bound by default to select-start(), which you are >wiping out. I did ask what this was and no-one replied. Now I know I will add it in.

>Also, this widget-callback-current-channel business has got to go. Why can't >this just be an argument to the callback? (Make it a function, not a form.) Huh? Your suggestion as I recall!!!! I don't think it can be an argument because of the various different types of callback that there are.

andy -------------------------------------------------------------- Dr Andy Piper Principal Consultant, BEA Systems Ltd

At 07:17 PM 4/15/00 -0700, Ben Wing wrote: >I did offer to fax you all the documentation. I don't have a fax machine.

>Don't you have access to the sources? The Athena widgets are open source. Somewhere maybe.

>I seriously doubt I made this suggestion, since it's so unclean. At 04:36 AM 4/7/00 -0700, Ben Wing wrote: >(2) [Better] Provide a way for callbacks to determine where they were invoked >at. This is much more general and is what you should really do. For example, >have the code that calls the callbacks bind some global variables such as >widget-callback-current-glyph and widget-callback-current-channel, which >contain the glyph >whose callback is being invoked, and the window or frame of the glyph >(depending on where the glyph is) where the invocation actually happened. >That way, the callbacks can easily figure out the dialog box and >its parent, and not have to worry about embedding it in at creation time. Obviously transatlantic differences in English meaning are larger than I thought. >I don't understand when you say "the various types of callback". Are you using >the callback for various different purposes? No. Callbacks are allowed to be many different things - some functions, others just forms or symbols.

>Your widget callbacks should work just like any other callback: they take two >arguments, one indicating the object to which the callback was attached (an image >instance, i think), and the event that caused the callback to be invoked. I'm obviously misunderstanding something here. andy -------------------------------------------------------------- Dr Andy Piper Principal Consultant, BEA Systems Ltd

At 05:58 PM 4/16/00 -0700, Ben Wing wrote: >"i don't feel like making the effort" isn't a very good excuse. If XEmacs was my full time job, maybe. But actually I *don't* feel like making the effort. Supporting Athena *at all* has been a tremendous pain for me. If you would rather I stop that suits me just fine. >it's very simple -- you defined the glyph widget api, including the :callback >keyword, so you can change it. none of your api is set in stone. you yourself >the only difference is that instead of calling "Feval", call "call2". This makes widget callbacks different from menubar and other callbacks. I don't think this is user friendly and in fact breaks abstraction IMO. Feval is not called in all cases - sometimes Fcall_interactively is used. I think the fact that you can just drop an existing function in as a callback is a Good Thing, so I think your latest suggestion is "unclean". Changing widget-callback-current-channel to a function is probably an ok thing to do.

andy -------------------------------------------------------------- Dr Andy Piper Principal Consultant, BEA Systems Ltd