9:35 p.m.
>>>> "Andy" == Andy Piper <andyp(a)bea.com>
writes:
Andy> Which next button is this?
Andy> Thanks
Oops, the test-case did not get archived on xemacs-beta.
See the thread starting with this:
http://www.xemacs.org/cgi-bin/wilma_hiliter/xemacs-beta/200010/msg00080.html
Here it (widget-activation-test.el) is again:
(defun widget-activation-test ()
"test-case exposing following problems:
In XEmacs 21.2-b36 vanilla \"i386-pc-win32\" the \"Next Button\" is
never rendered inactive.
In XEmacs 21.1.12 vanilla \"i386-pc-win32\" the \"Next Button\" is
correctly rendered inactive, BUT is not dispalayed as active again
(after pressing \"Activate Next Button\") until it is pressed!
In both, when going back from \"Next Button\" with
Sh-TAB runs `widget-backward',
the caret is not displayed until
C-l runs `recenter'
is pressed.
In both
Sh-TAB runs `widget-backward',
circles through all buttons in the buffer (wrapping around) while
TAB runs `widget-forward'
does not. It leaves caret at the last button in the buffer.
"
(interactive)
(kill-buffer (get-buffer-create "*widget-activation-test*"))
(switch-to-buffer (get-buffer-create "*widget-activation-test*"))
(kill-all-local-variables)
(setq toggle-button
(widget-create 'push-button
:notify (lambda (&rest ignore)
(cond ((widget-apply next-button :active)
(widget-apply next-button :deactivate)
(widget-value-set
toggle-button
"Activate Next Button"))
(t
(widget-apply next-button :activate)
(widget-value-set
toggle-button
"Deactivate Next Button"))))
"Deactivate Next Button"))
(widget-insert "\n")
(setq
next-button
(widget-create 'push-button
:notify (lambda (&rest ignore)
(message (current-time-string)))
"Next Button (current-time-string)"))
(use-local-map widget-keymap)
(widget-setup))
Hope this helps,
Adrian
Andy> andy
Andy> At 12:30 08/10/00 +0200, Adrian Aichner wrote:
> >>>>> "APA" == Adrian Aichner
<adrian(a)xemacs.org> writes:
>
> Hello Andy,
>
> following change seems to blame for following problem in 21.2-b36 (and
> previous version) (see test-case in <uk8bk1kk1.fsf(a)ecf.teradyne.com>):
>
> In XEmacs 21.2-b36 vanilla \"i386-pc-win32\" the \"Next Button\"
is
> never rendered inactive.
>
> Index: wid-edit.el
> ===================================================================
> RCS file: /usr/CVSroot/XEmacs/xemacs/lisp/wid-edit.el,v
> retrieving revision 1.11.2.6
> retrieving revision 1.11.2.7
> diff -u -u -r1.11.2.6 -r1.11.2.7
> --- wid-edit.el 1999/07/06 07:33:02 1.11.2.6
> +++ wid-edit.el 1999/10/20 07:14:33 1.11.2.7
> ＠＠ -1935,16 +1935,11 ＠＠
> (console-on-window-system-p))
> (unless gui-glyphs
> (let* ((gui-button-shadow-thickness 1)
> - (gui (make-gui-button tag 'widget-gui-action widget)))
> - (setq
> - gui-glyphs
> - (list
> - (make-glyph `(,(nth 0 (aref gui 1)) [string :data ,text]))
> - (make-glyph `(,(nth 1 (aref gui 1)) [string :data ,text]))
> - (make-glyph `(,(nth 2 (aref gui 1)) [string :data ,text]))))
> + (gui (make-glyph
> + (make-gui-button tag 'widget-gui-action widget))))
> + (setq gui-glyphs gui)
> (laxputf widget-push-button-cache tag gui-glyphs)))
> - (widget-glyph-insert-glyph
> - widget (nth 0 gui-glyphs) (nth 1 gui-glyphs) (nth 2 gui-glyphs)))
> + (widget-glyph-insert-glyph widget gui-glyphs))
> (t
> (insert text)))))
>
> Could you please comment. I would like to fix this.
>
> Best regards,
>
> Adrian
>
APA> Hello Per, Hrvoje, All!
>
APA> If you could give me some guidance/hints I am
willing to look into
APA> these problems/features and come up with patches.
>
APA> In particular I would like the fix the button
active/inactive
> display
APA> problems.
>
APA> Here's the self-documenting test-case:
>
>
>
APA> Thanks,
>
APA> Adrian
>
APA> --
APA> Adrian Aichner <adrian(a)xemacs.org>, http://www.xemacs.org
>
>> --
>> Adrian Aichner <adrian(a)xemacs.org>, http://www.xemacs.org
Andy> --------------------------------------------------------------
Andy> Dr Andy Piper
Andy> Principal Consultant, BEA Systems Ltd
--
Adrian Aichner
mailto:adrian＠xemacs.org
http://www.xemacs.org/
9:44 p.m.
New subject: Problems with widgets in 21.1.12 and 21.2-b36 vanilla
At 22:35 12/01/01 +0100, Adrian Aichner wrote:
>>>>> "Andy" == Andy Piper
<andyp(a)bea.com> writes:
Andy> Which next button is this?
Andy> Thanks
Oops, the test-case did not get archived on xemacs-beta.
See the thread starting with this:
http://www.xemacs.org/cgi-bin/wilma_hiliter/xemacs-beta/200010/msg00080.html
This is an interesting bug. It actually reveals some deficiencies in the
widget code. This fixes. There are some netinstall fixes and glyph
documnetation at the end.
andy
2001-01-17 Andy Piper <andy(a)xemacs.org>
* wid-edit.el (widget-activation-glyph-mapper): activate or
deactivate native widgets.
(widget-glyph-insert-glyph): record instantiator.
(widget-push-button-value-create): use it.
* gui.el (gui-button-action): new function. Make button's domain
buffer current when calling.
(make-gui-button): update to use gui-button-action.
2001-01-17 Andy Piper <andy(a)xemacs.org>
* glyphs.c (print_image_instance): comment to make martin happy.
* glyphs-x.c (x_redisplay_widget): update faces after a frame
change.
* glyphs-msw.c (mswindows_redisplay_widget): add code to cope with
activation.
(mswindows_tab_control_redisplay): warning suppression.
* glyphs-widget.c (widget_update): re-write to cope with updated
items.
(widget_instantiate): use new gui_item functions.
(tab_control_update): deleted.
(progress_gauge_update): deleted.
(image_instantiator_progress_guage): take out update reference.
(image_instantiator_tree_view): ditto.
(image_instantiator_tab_control): ditto.
* gui.c (widget_gui_parse_item_keywords): new function. Do things
Right the new way.
(gui_item_add_keyval_pair): re-write to cope with descriptors and
return whether anything was changed.
(update_gui_item_keywords): as it sounds.
* gui.h: declare widget_gui_parse_item_keywords.
* fns.c (safe_copy_tree): new function taken from Fcopy_tree.
(Fcopy_tree): use it. Stops infloop death in bogus instantiators.
2001-01-17 Andy Piper <andy(a)xemacs.org>
* ini.h: move extern "C" to aid win32 compilation. From Fabrice
Popineau.
2001-01-12 Andy Piper <andy(a)xemacs.org>
* package-get.el (package-get-custom): call
package-net-update-installed-db.
* package-ui.el (pui-install-selected-packages): call
package-net-update-installed-db.
* package-net.el (package-net-update-installed-db): use
packages-package-list so that we reflect reality.
* packages.el (packages-package-list): Make docstring reflect
reality.
* package-net.el (package-net-convert-index-to-ini): exclude mule
entries.
* postinstall.cc (do_postinstall): don't pick up shells if cygwin
isn't installed.
--------------------------------------------------------------
Dr Andy Piper
Principal Consultant, BEA Systems Ltd
8705
days inactive
8710
days old
1 comments
2 participants
participants (2)
-
Adrian Aichner -
Andy Piper