At 23:16 05/07/98 -0700, SL Baur wrote:
Andy Piper <andyp(a)parallax.co.uk> writes:
> Steve, Oliver, Bill,
> Can you see if this patch fixes your toolbar gripes.
It does. :-) It also fixes the modeline lossage[1]. Was this intended
(I hope, I hope)?
Yes. Also as a serendipitous side-effect this actually makes the modeline
do what everyone wanted in the first place and preserves Kyles desired
behavior. i.e. -bg or background sets everything, however if you just set
the default face background color the color of the rest of the widgets
remain unchanged (including the modeline). Hopefully everyone is happy now.
The only remaining bug is that setting the gui-face in custom doesn't get
read soon enough and when it does doesn't affect the shadows of things
(Oscar's observed behaviour). However, given that this is a new feature
anyway for 21.0 and is hard to fix easily, I would suggest we leave it
undocumented for 21.0 and fix it properly for 21.1. The effect I wanted
(correct toolbar color under mswindows) has already been satisfied.
Please send along the ChangeLog entries so I can put this in
pre4/Uzbek Black. Thanks.
BTW this includes the x-faces.el patch so don't try applying that anymore.
1998-07-065 Andy Piper <andyp(a)parallax.co.uk>
* faces.el (xpm-color-symbols): remove hardcoded defaults these
are handled by the gui-element face fallbacks now.
* x-faces.el: default gui-element face to "background" as well as
the default face.
* msw-faces.el (mswindows-init-device-faces): remove gui-element
and default face settings since these are set as fallbacks now in
the appropriate domain.
* faces.c (complex_vars_of_faces): for the gui-element face don't
fallback to the default face, instead provide reasonable default
fallbacks that were previously hardcoded elsewhere.
andy
---------------------------------------------------------------------------
" .sigs are like your face - rarely seen by you and uglier than you think"
Dr Andy Piper, Technical Architect, Parallax Solutions Ltd
mail: andyp(a)parallax.co.uk web:
www.parallax.co.uk/~andyp