[patch] correct fix (Was: Fix for Re: Bug (I think) limit on popup menu strings)

Friday, 5 June 1998

        Jeff Miller writes:

...
 I believe I have found the culprit.  If you look at xlwmenu.c,
function
 "string_width_u", you'll see that it has a 64 long char array called
 newchars.  I don't follow all that's going on in here, but this function
 appear to clean up the text string and null-terminate it.   
...
 The 64 char arry obviously limits the length of the popup menu, so
I'm
 jacking it up to 256. 
It is always a bad idea to put limits on strings.

...
 Seocond, there is an off-by-one count on the null termination of
 newchars.  So I fixed that too. 
Here is a patch that also works, but sets no limit on the length of
the string.

[ Note that I used text/plain instead of application/octet-stream]

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998