At 04:12 PM 5/24/00 +0100, Jan Vroonhof wrote:
1. Shouldn't locative and/or governingdomain
be GCRPO'ed?, instantiate_image_instantiator gcpro's its variables.
Isn't this implicitly GCPRO'd by the record_unwind_protect?
2. Isn't it possible that DEVICEP(governing_domain) is true, but
domain is a window?. In that case
Its possible but cache_subwindow_instance_in_frame_maybe only records the
instance if it is a widget and widgets have a window governing domain. And
it is only the governing_domain that is recorded in the widget. I guess it
would be more correct for cache_subwindow_instance_in_frame_maybe to use
the domain of the instance (for example:
if (!NILP (DOMAIN_FRAME (IMAGE_INSTANCE_DOMAIN (value))))
{
...
but I can't see that that is going to make any difference.
cache_subwindow_instance_in_frame_maybe might add it to the frame
cache but it won't be in the window cache, so mark_window_as_deleted does
not see it?
I suppose it might be worth rewriting your sledgehammer check to validate
that for every instance in the frame cache its domain is (a) a window and
(b) in that window's cache.
I'm wondering whether the minibuffer window is to blame here.
set_window_configuration does some wierd stuff if it finds this - although
the fact that the deleted window is the Arcticle buffer seems to indicate
against this.
andy
--------------------------------------------------------------
Dr Andy Piper
Principal Consultant, BEA Systems Ltd