5:16 a.m.
>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
SY> APPROVE
SY> [ Apologies for the long delay in responding. ]
That's OK, I've been waiting for someone to tell me whether I've done
something wrong or found an XEmacs bug before self-approving it...
:-(
SY> [...]
SY> Seeing as though the code in this patch that breaks XEmacs is
SY> commented out, I'm happy for it to be committed. But before
SY> you do, please do a ChangeLog entry for it and commit that
SY> also.
Oh yeah... dumb question: do the ChangeLog entries have to be in
date order? The corresponding entry from my local RCS log has a date
of 2002-06-11, which has already been passed in the prog-modes
ChangeLog. If they have to be in order, should I always change that
date to the commit date?
I also notice that the dates got out of order when I last
committed...:-(
By the way, I'd really like to try and solve the problem before I
commit the code. The alternative is to disabled the offending code
when running under XEmacs and enable it for GNU Emacs. However,
without the waiting code, the results can be strange if the user hits
enter too quickly... :-(
Is there someone in particular worth hassling about why
(eq (process-status proc) 'run)
is t when the process is a zombie? In my particular case, if XEmacs
did a wait*() to cleanup the child, it wouldn't matter anyway. For
some reason XEmacs is updating the display but not reaping dead
children...:-(
Thanks...
peace & happiness,
martin
3:15 p.m.
New subject: [A] Re: [Q] [PATCH] prog-modes: eiffel.el - Add function eif-debug
|--==> "MS" == Martin Schwenke <martin(a)meltin.net> writes:
MS> Oh yeah... dumb question: do the ChangeLog entries have to be in
MS> date order?
No.
MS> By the way, I'd really like to try and solve the problem before I
MS> commit the code.
Yep, cool.
MS> Is there someone in particular worth hassling about why
MS> (eq (process-status proc) 'run)
MS> is t when the process is a zombie? In my particular case, if XEmacs
MS> did a wait*() to cleanup the child, it wouldn't matter anyway. For
MS> some reason XEmacs is updating the display but not reaping dead
MS> children... :-(
The first two people I'd be asking would be Ben Wing or Martin
Buchholz. Unfortunately, Ben has just started a vacation in Italy and
Martin is on a sabbatical of unknown duration.
Ben is still contactable at <ben_wing(a)hotmail.com> (I'll leave it to
you to decide whether or not you wish to interrupt his vacation), and
I'm not sure if Martin is answering his <martin(a)xemacs.org>.
Or maybe Steve Turnball or Hrvoje Niksic, both of which watch this
list closely and will see that I've whispered their names and that
they should dust of their guru hats. :-)
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
1:21 a.m.
New subject: [A] Re: [Q] [PATCH] prog-modes: eiffel.el - Add function eif-debug
>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
MS> is t when the process is a zombie? In my particular case, if
MS> XEmacs did a wait*() to cleanup the child, it wouldn't matter
MS> anyway. For some reason XEmacs is updating the display but
MS> not reaping dead children... :-(
SY> The first two people I'd be asking would be Ben Wing or Martin
SY> Buchholz. Unfortunately, Ben has just started a vacation in
SY> Italy and Martin is on a sabbatical of unknown duration.
Nix is the guy to ask, I think. He had a flurry of patches about race
conditions etc related to the process code. Kyle Jones had some
input, too.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
My nostalgia for Icon makes me forget about any of the bad things. I don't
have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py
11:30 p.m.
New subject: [A] Re: [Q] [PATCH] prog-modes: eiffel.el - Add function eif-debug
On 26 Jun 2002, Stephen J. Turnbull mused:
>>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
MS> is t when the process is a zombie? In my particular case, if
MS> XEmacs did a wait*() to cleanup the child, it wouldn't matter
MS> anyway. For some reason XEmacs is updating the display but
MS> not reaping dead children... :-(
SY> The first two people I'd be asking would be Ben Wing or Martin
SY> Buchholz. Unfortunately, Ben has just started a vacation in
SY> Italy and Martin is on a sabbatical of unknown duration.
Nix is the guy to ask, I think. He had a flurry of patches about race
conditions etc related to the process code. Kyle Jones had some
input, too.
Hm, well, I think I know what goes on here.
The process is reaped by a SIGCHLD handler (record_exited_processes(),
called by sigchld_handler() and by unix_reap_exited_processes()). As
such, if it's not reaped, then XEmacs hasn't noticed about it yet,
probably because the OS hasn't bothered to deliver a SIGCHLD, or XEmacs
has SIGCHLD blocked.
The process status itself is updated to Qstop principally in
unix_reap_exited_processes(), which is called from status_notify(),
which is called from the main event loop. Now I think about it this
seems rather broken because it means that PROCESS_LIVE_P will return t
(with all that that implies) between a process dying and the event loop
being called. Is there a reason why we don't change the status to Qexit
at the time the process dies?
(Note that the `old' method of determining if a process is dead (before
my patch), which was to look at its pipe_instream, was just as broken,
because that too was only updated in the main event loop.)
I can produce a patch if anyone cares enough ;}
--
`What happened?'
`Nick shipped buggy code!'
`Oh, no dinner for him...'
3:50 a.m.
New subject: [A] Re: [Q] [PATCH] prog-modes: eiffel.el - Add function eif-debug
>>>> "nix" == nix
<nix(a)esperi.demon.co.uk> writes:
nix> I can produce a patch if anyone cares enough ;}
Somebody always cares enough to take that offer.
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
My nostalgia for Icon makes me forget about any of the bad things. I don't
have much nostalgia for Perl, so its faults I remember. Scott Gilbert c.l.py
6:20 a.m.
New subject: [A] Re: [Q] [PATCH] prog-modes: eiffel.el - Add function eif-debug
>>>> "Nix" == Nix
<nix(a)esperi.demon.co.uk> writes:
MS> is t when the process is a zombie? In my particular case, if
MS> XEmacs did a wait*() to cleanup the child, it wouldn't matter
MS> anyway. For some reason XEmacs is updating the display but
MS> not reaping dead children... :-(
Nix> [...]
Nix> I can produce a patch if anyone cares enough ;}
Yes please, I care a lot... :-)
Thanks...
peace & happiness,
martin
8183
days inactive
8186
days old
5 comments
4 participants
participants (4)
-
Martin Schwenke -
Nix -
Stephen J. Turnbull -
Steve Youngs