Ar an séú lá déag de mí Feabhra, scríobh Mats Lidell:
>>>>> Jeff Sparkes <jsparkes(a)gmail.com> writes:
Jeff> Where is it getting acons from? It's not in the source any
Jeff> more, or in the object files.
It is in xemacs.def and used by dlltool to produce xemacs-export.o
which then contains an undefined reference to '_acons'
This was my next question. If Aidans patch simply made acons in C
visible instead of acons in lisp why do we get the undefined
reference?
Removing acons from xemacs.def fixes the undefined reference but it is
right, does it undermine anything for the modules?
Not in practice, none of the modules appear to use it. But if people felt it
appropriate to export acons(), then it’s equally appropriate to export
Facons() to the modules. I’ve just committed the below, thanks for the
reports.
APPROVE COMMIT
NOTE: This patch has been committed.
# HG changeset patch
# User Aidan Kehoe <kehoea(a)parhasard.net>
# Date 1297870535 0
# Node ID 503b9a3e5e4618f16972523c9e6d9fdacb285ba3
# Parent 5dd1ba5e01137d935224d5156fe55ac773844eaf
xemacs.def.in.in: no longer export acons(), export Facons() instead.
2011-02-16 Aidan Kehoe <kehoea(a)parhasard.net>
* xemacs.def.in.in:
No longer export acons(), export Facons() instead, thank you Mats,
Jerry and Jeff Sparkes.
diff -r 5dd1ba5e0113 -r 503b9a3e5e46 src/ChangeLog
--- a/src/ChangeLog Sat Feb 12 14:07:38 2011 +0000
+++ b/src/ChangeLog Wed Feb 16 15:35:35 2011 +0000
@@ -1,3 +1,9 @@
+2011-02-16 Aidan Kehoe <kehoea(a)parhasard.net>
+
+ * xemacs.def.in.in:
+ No longer export acons(), export Facons() instead, thank you Mats,
+ Jerry and Jeff Sparkes.
+
2011-02-10 Aidan Kehoe <kehoea(a)parhasard.net>
* fns.c (shortest_length_among_sequences):
diff -r 5dd1ba5e0113 -r 503b9a3e5e46 src/xemacs.def.in.in
--- a/src/xemacs.def.in.in Sat Feb 12 14:07:38 2011 +0000
+++ b/src/xemacs.def.in.in Wed Feb 16 15:35:35 2011 +0000
@@ -34,7 +34,6 @@
NAME xemacs.exe
EXPORTS
/* Exported functions */
-acons
#ifdef NEW_GC
alloc_lrecord /* ALLOC_LISP_OBJECT */
alloc_sized_lrecord /* ALLOC_SIZED_LISP_OBJECT */
@@ -249,6 +248,7 @@
Dynarr_insert_many /* Dynarr_add_{literal,lisp}_string */
Dynarr_newf /* Dynarr_new, Dynarr_new2 */
Dynarr_resize /* Dynarr_add */
+Facons
Fappend
Fapply
Fbuffer_modified_p
--
“Apart from the nine-banded armadillo, man is the only natural host of
Mycobacterium leprae, although it can be grown in the footpads of mice.”
-- Kumar & Clark, Clinical Medicine, summarising improbable leprosy research
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta