7:46 a.m.
Sorry for delay. I'll try to review patches as soon as
possible but I've been busy and I cannot promise when it
will be done. I wish patch submitters won't be disappointed
by slow reviewing and will be continuing to hack XEmacs.
1999-11-18 Tim Bradshaw
Hack fix for prefix help in xemacs 21
<199911180102.BAA21598(a)lostwithiel.tfeb.org>
http://list-archive.xemacs.org/xemacs-patches/199911/msg00063.html
Status: Not reviewed
1999-12-29 Kevin Delia
Fix for ps-print.el used by NT XEmacs
<386A47EC.DCFBB7B7(a)globalone.net>
http://list-archive.xemacs.org/xemacs-patches/199912/msg00158.html
Status: Not reviewed
Steve Youngs will look into this.
2000-01-14 Karl M. Hegbloom
man.el: Take 3 **IGNORE PREVIOUS PATCHES**
<874schjf6c.fsf(a)bittersweet.intra>
http://list-archive.xemacs.org/xemacs-patches/200001/msg00069.html
Status: Not reviewed
Steve Youngs will look into this.
2000-01-25 Robert.Fenk(a)gmx.de
smtpmail-sent-it extracts RESENT-* headers wrong!
<14477.29922.17067.523087(a)sunwibas14.forwiss.tu-muenchen.de>
http://list-archive.xemacs.org/xemacs-patches/200001/msg00196.html
Status: Not reviewed
Sent to Simon Josefsson (mail-lib maintainer)
2000-03-09 Rodney Stromlund
Using wget to download packages
<s8c7798e.082(a)hdqmail.swacorp.com>
http://list-archive.xemacs.org/xemacs-patches/200003/msg00059.html
Status: Not reviewed
2000-06-07 MORIOKA Tomohiko
eliminate hard coding parts about charset
<htxbt1dsqhy.fsf(a)urania.kanji.zinbun.kyoto-u.ac.jp>
http://list-archive.xemacs.org/xemacs-patches/200006/msg00020.html
Status: Not reviewed
2000-08-31 QuoteMstr
Better C++ IMenu support
<20000830205905.A29419(a)d30-146.hcvlny.optonline.net>
http://list-archive.xemacs.org/xemacs-patches/200008/msg00108.html
Status: Not reviewed
Steve Youngs will look into this.
2000-10-04 Darryl Okahata
Getting the pixel position of a window point
<200010041837.LAA29896(a)mina.soco.agilent.com>
http://list-archive.xemacs.org/xemacs-patches/200010/msg00020.html
Status: Approved
2000-11-12 Klaus Frank
Info fixes, Info-emacs-key, PR#1501-1503
<200011121459.PAA09119(a)pfitzner.informatik.rwth-aachen.de>
http://list-archive.xemacs.org/xemacs-patches/200011/msg00056.html
Status: Approved with mod
Need to fix example.
2000-11-13 Sean MacLennan
Re: package-get-hook
<14863.24170.700206.526947(a)fillmore.storm.ca>
http://list-archive.xemacs.org/xemacs-patches/200011/msg00060.html
Status: Approved
Steve Youngs will look into this.
2000-11-14 I.Sheldon
change-request: vc.el to allow template text in vc log buffer
<m2n1f2jnrv.fsf(a)zeus.kaidea.freeserve.co.uk>
http://list-archive.xemacs.org/xemacs-patches/200011/msg00075.html
Status: Not reviewed
Steve Youngs will look into this.
2000-11-19 Gregory Neil Shapiro
21.2.36: New movemail option to remove inbox instead of truncate
<14872.11701.215292.104315(a)horsey.gshapiro.net>
http://list-archive.xemacs.org/xemacs-patches/200011/msg00110.html
Status: Approved with mod
Need to fix spurious ftruncate
2000-12-14 Tetsuo Tsukamoto
do-auto-fill fix for MULE
<sa6hf482cq5.fsf(a)remus.dti.ne.jp>
http://list-archive.xemacs.org/xemacs-patches/200012/msg00052.html
Status: Not reviewed
2000-12-19 Golubev I. N.
sendmail prog & originator
<02453a3fac4701-gin(a)mo.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200012/msg00068.html
Status: Not reviewed
Sent to Simon Josefsson (mail-lib maintainer)
2000-12-28 Kevin Gallagher
Patch to EDT package. Now works in XEmacs.
<3A4BA766.C4A5ABDB(a)onramp.net>
http://list-archive.xemacs.org/xemacs-patches/200012/msg00089.html
Status: Not reviewed
Steve Youngs will look into this.
2001-01-05 Golubev I. N.
xemacs_stat
<02e83a560c9b32-gin(a)mo.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200101/msg00010.html
Status: Not reviewed
2001-01-09 Daniel Pittman
VC60 support for compile.el
<87g0it9x7w.fsf(a)inanna.rimspace.net>
http://list-archive.xemacs.org/xemacs-patches/200101/msg00027.html
Status: Not reviewed
2001-01-09 Golubev I. N.
`stat' in "lisp.h"
<02e83a5b113434-gin(a)mo.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200101/msg00034.html
Status: Not reviewed
2001-01-20 Nick V. Pakoulin
Default values when reading from minibuffer in some cases.
<scmae8mz89h.fsf(a)hookah.kazbek.ispras.ru>
http://list-archive.xemacs.org/xemacs-patches/200101/msg00132.html
Status: Approved
2001-01-29 Karl M. Hegbloom
mwheel.el: support left and right scroll also
<87ofwqmf4t.fsf(a)karlheg.microsharp.com>
http://list-archive.xemacs.org/xemacs-patches/200101/msg00184.html
Status: Not reviewed
2001-02-05 Jerry James
Enable module building
<ps1ytcogrq.fsf(a)diannao.ittc.ukans.edu>
http://list-archive.xemacs.org/xemacs-patches/200102/msg00021.html
Status: Not reviewed
2001-02-08 Jean-Yves Burlett
Solves curses detection/terminal garbled problem on OpenBSD
<us84ry5w2py.fsf(a)poseidon.ifsic.univ-rennes1.fr>
http://list-archive.xemacs.org/xemacs-patches/200102/msg00040.html
Status: Discussion
2001-02-16 Simon Josefsson
mail-lib/rmailout.el
<iluzofnvsm7.fsf(a)barbar.josefsson.org>
http://list-archive.xemacs.org/xemacs-patches/200102/msg00094.html
Status: Unknown
2001-04-25 Albert L. Ting
Re: vc-hooks.el patch
<15079.331.923129.704788(a)betty.artisan.com>
http://list-archive.xemacs.org/xemacs-patches/200104/msg00100.html
Status: Approved
2001-04-25 Stephen J. Turnbull
[packages] Change bug address in emacsbug.el
<15078.34617.367597.513600(a)turnbull.sk.tsukuba.ac.jp>
http://list-archive.xemacs.org/xemacs-patches/200104/msg00093.html
Status: Discussion
There has been some discussion but no agreement is reached yet.
2001-04-29 Simon Josefsson
new subr.el function: make-temp-file
<ilu7l04eeol.fsf(a)barbar.josefsson.org>
http://list-archive.xemacs.org/xemacs-patches/200104/msg00122.html
Status: Discussion
Can't apply as is. We need to enhance write-region.
2001-05-17 Stephen J. Turnbull
[21.5] Partial support for missing XPM (NT guys, please review)
<15107.55639.829410.755251(a)turnbull.sk.tsukuba.ac.jp>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00105.html
Status: Approved
2001-05-17 Stephen J. Turnbull
[21.5] Partial support for WinME (NT guys, please review)
<15107.55655.214316.248415(a)turnbull.sk.tsukuba.ac.jp>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00107.html
Status: Approved
2001-05-17 Andrew Begel
bug fix for xemacs config macros for finding ld on unix
<B729780C.45534%abegel(a)eecs.berkeley.edu>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00112.html
Status: Not reviewed
2001-05-17 Andrew Begel
bug fix for defining types in external modules
<B72977D8.45533%abegel(a)eecs.berkeley.edu>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00111.html
Status: Not reviewed
2001-05-17 Stephen J. Turnbull
[21.5, 21.4] Use EMACS_PATCH_LEVEL in NT builds
<15107.55648.69094.173626(a)turnbull.sk.tsukuba.ac.jp>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00106.html
Status: Approved
2001-05-20 Mike Alexander
MSWindows printer patches
<15939238.3199313137(a)mta-1.pnet.msen.com>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00126.html
Status: Not reviewed
2001-05-20 Isaac Hollander
PROBLEMS addition for esound troubles
<200105210224.WAA14686(a)maynard.mail.mindspring.net>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00137.html
Status: Not reviewed
2001-05-20 Adrian Aichner
[PATCH] Experimental mswindows_utime implementation by Ben
<1yplynmo.fsf(a)rapier.ecf.teradyne.com>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00117.html
Status: Not reviewed
2001-05-24 Kirill 'Big K' Katsnelson
[PATCH] COM character type fix
<4.3.2.7.2.20010524160839.02dfa610＠pop>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00159.html
Status: Approved
Self approval by the reviewer.
2001-05-27 Kazuo Oishi
new version of xemacs-ja.1
<87bsof9zbk.fsf(a)n-pl.org>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00177.html
Status: Not reviewed
2001-05-28 Paul Krause
[PATCH] fix check for Cygwin Perl in DEPEND
<FENWAYUfKRfcjcMzfoV00000f4e(a)fenway.corp.soundbite.com>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00183.html
Status: Not reviewed
2001-05-31 Paul Stodghill
Changes to get Ben's changes to compile under cygwin.
<yz17kyxzij2.fsf(a)milhouse.cs.cornell.edu>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00199.html
Status: Not reviewed
2001-06-04 IKEYAMA Tomonori
Re: Use i.exe and cygpath during build
<r8x1vugz.fsf(a)suiyokai.org>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00012.html
Status: Not reviewed
2001-06-05 Andrew Begel
[PATCH] supporting dynamic modules on Windows
<B7D7A2ED64049746BBCDFB0DA028CC5404A55C(a)ups.millennium.berkeley.edu>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00015.html
Status: Not reviewed
2001-06-06 melwin(a)mail.securant.com
Small hack to prevent crash when scrolling in Windows.
<200106061411999.SM00784＠m2w037>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00022.html
Status: Not reviewed
2001-06-06 Alexey Mahotkin
[PATCH] Mule (and fonts) corrections to the manual
<15133.17889.988505.202517(a)tyranny.hsys.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00016.html
Status: Not reviewed
2001-06-06 Raymond Toy
pcl-cvs and vc-comment-ring
<4n7kypwqls.fsf(a)rtp.ericsson.se>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00021.html
Status: Not reviewed
2001-06-07 Mark Thomas
Gnus fix: nnmail.el: nnmail-fix-eudora-headers regexp
<wf1snhckvbp.fsf(a)svelte.home>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00026.html
Status: Unknown
2001-06-08 Matt Curtin
patch: Galeon support in browse-url.el
<15137.35600.614551.972317(a)animal.interhack.net>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00030.html
Status: Not reviewed
2001-06-12 Alexey Mahotkin
[PATCH] One more bug in help.el (and find-func.el) (Was: Bug in help.el)
<87zobdrfjw.fsf_-_(a)tyranny.hsys.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00052.html
Status: Unknown
Will review later.
2001-06-13 Stephen J. Turnbull
Port XEmacs to WinME [21.4, 21.5]
<15142.14867.525787.322728(a)turnbull.sk.tsukuba.ac.jp>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00053.html
Status: Unknown
He said he'll apply but I don't think it has been applied to 21.5.
2001-06-14 Alexey Mahotkin
Re: Mule: (upcase-region-or-word) doesn't work for Russian
<87bsnqrh9o.fsf(a)tyranny.hsys.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00061.html
Status: Approved
2001-06-15 QuoteMstr - Danny Colascione
Patch for shifted motion keys
<20010615033926.A19781(a)ool-18b88ad6.dyn.optonline.net>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00063.html
Status: Unknown
Will review later.
2001-06-15 Nick Pakoulin
Re: Bug in help.el
<uofrqvxzn.fsf(a)ispras.ru>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00064.html
Status: Unknown
Neither vetoed or approved.
2001-06-15 Golubev I. N.
sco5 clone pty
<4fa13b29a52a70-gin(a)mo.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00062.html
Status: Not reviewed
2001-06-16 Simon Josefsson
zenirc/zenirc.el font-lock support
<ilu4rtgp89x.fsf(a)barbar.josefsson.org>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00070.html
Status: Not reviewed
2001-06-21 Jeff Mincy
mailcrypt issue
<15154.13244.200000.298131(a)antarres.muniversal.com>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00087.html
Status: Not reviewed
2001-06-21 Jeff Mincy
Re: diff-mode for vc-backend-diff
<15154.36617.520000.343968(a)antarres.muniversal.com>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00090.html
Status: Not reviewed
2001-06-24 Nuutti Kotivuori
Bugfix for read-passwd-1
<87elsaodmy.fsf(a)smarttrust.com>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00096.html
Status: Not reviewed
2001-07-01 Alexey Mahotkin
Fix to configure.in to _not_ compile in Xaw when not requested
<15167.31192.971882.809294(a)tyranny.hsys.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200107/msg00000.html
Status: Not reviewed
--
Yoshiki Hayashi
1:16 p.m.
Yoshiki Hayashi <yoshiki(a)xemacs.org> writes:
2000-01-25 Robert.Fenk(a)gmx.de
smtpmail-sent-it extracts RESENT-* headers wrong!
<14477.29922.17067.523087(a)sunwibas14.forwiss.tu-muenchen.de>
http://list-archive.xemacs.org/xemacs-patches/200001/msg00196.html
Status: Not reviewed
Sent to Simon Josefsson (mail-lib maintainer)
It's applied.
2000-12-19 Golubev I. N.
sendmail prog & originator
<02453a3fac4701-gin(a)mo.msk.ru>
http://list-archive.xemacs.org/xemacs-patches/200012/msg00068.html
Status: Not reviewed
Sent to Simon Josefsson (mail-lib maintainer)
I'll suggest this to the Emacs maintainers first, it looks good.
2001-06-07 Mark Thomas
Gnus fix: nnmail.el: nnmail-fix-eudora-headers regexp
<wf1snhckvbp.fsf(a)svelte.home>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00026.html
Status: Unknown
FWIW, this was applied to Gnus CVS and is good.
2001-06-08 Matt Curtin
patch: Galeon support in browse-url.el
<15137.35600.614551.972317(a)animal.interhack.net>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00030.html
Status: Not reviewed
It's applied.
6:08 a.m.
--On Tuesday, July 03, 2001 3:46 PM +0900 Yoshiki Hayashi <yoshiki(a)xemacs.org>
wrote:
2001-05-20 Mike Alexander
MSWindows printer patches
<15939238.3199313137(a)mta-1.pnet.msen.com>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00126.html
Status: Not reviewed
The first part of this has been applied and the second part was never meant to
be applied in this form. It prompted a discussion about the real nature of the
problem which I more or less resolved. I consider this patch closed.
Mike Alexander mailto:mta＠arbortext.com
Arbortext, Inc. +1-734-997-0200
6:57 p.m.
From: "Yoshiki Hayashi" <yoshiki(a)xemacs.org>
2001-06-06 melwin(a)mail.securant.com
Small hack to prevent crash when scrolling in Windows.
<200106061411999.SM00784＠m2w037>
http://list-archive.xemacs.org/xemacs-patches/200106/msg00022.html
Status: Not reviewed
This is already fixed by Ben's patch of 2001-05-19, and should not be
applied.
2001-05-19 Ben Wing <ben(a)xemacs.org>
[PATCH] a few fixes
Id: <200105200118.VAA32224(a)gwyn.tux.org>
http://list-archive.xemacs.org/xemacs-patches/200105/msg00124.html
* event-msw.c (mswindows_find_frame):
we might receive scrollbar events on windows without scrollbars
(e.g. holding down and moving the wheel button).
6:39 p.m.
(I hope most xemacs-mule people are on this list as well.)
Yoshiki Hayashi <yoshiki(a)xemacs.org> writes:
2001-04-29 Simon Josefsson
new subr.el function: make-temp-file
<ilu7l04eeol.fsf(a)barbar.josefsson.org>
http://list-archive.xemacs.org/xemacs-patches/200104/msg00122.html
Status: Discussion
Can't apply as is. We need to enhance write-region.
It would be nice to resolve this.
Problem: `write-region' take different parameters in XEmacs and Emacs,
in XEmacs:
,----
| (write-region START END FILENAME &optional APPEND VISIT LOCKNAME CODING-SYSTEM)
|
| Optional seventh argument CODING-SYSTEM specifies the coding system
| used to encode the text when it is written out, and defaults to
| the value of `buffer-file-coding-system' in the current buffer.
| Interactively, with a prefix arg, you will be prompted for the
| coding system.
`----
and in Emacs:
,----
| (write-region START END FILENAME &optional APPEND VISIT LOCKNAME MUSTBENEW)
|
| The optional seventh arg MUSTBENEW, if non-nil, insists on a check
| for an existing file with the same name. If MUSTBENEW is `excl',
| that means to get an error if the file already exists; never overwrite.
| If MUSTBENEW is neither nil nor `excl', that means ask for
| confirmation before overwriting, but do go ahead and overwrite the file
| if the user confirms.
`----
Grep:ing through the XEmacs core I can't find anywhere where the
CODING-SYSTEM parameter is used. Neither in XEmacs mule packages.
Grep:ing through the XEmacs packages I can find at least one place
where it is used INCORRECTLY. (`ediff-make-empty-tmp-file')
CODING-SYSTEM is used in jka-compr.el, mule-sysdp.el and nnmail.el,
but seems to be there just because they provide wrappers for
write-region.
I can't find anywhere it's really used with a coding-system argument.
(Except in documentation.)
Solving this is necesary to create a secure `make-temp-file' -- I may
recall incorrectly, but I think there has been some security reports
about Mailcrypt or similar PGP packages being insecure because of
this. XEmacs is still vulnerable..
How about ditching the CODING-SYSTEM parameter in favor of the
MUSTBENEW?
I don't care much if this is fixed in `write-region' or elsewhere --
what I'm after is a secure way to create temporary files. A
alternative to changing `write-region' is to implement
`make-temp-name' in C.
(Of course, `write-region' could look at the argument to see if it is
a coding system or not and support both XEmacs and Emacs syntax. But
it's not nice.)
Any ideas?
9:28 a.m.
>>>> "Simon" == Simon Josefsson
<jas(a)extundo.com> writes:
Simon> Optional seventh argument CODING-SYSTEM
We should make all of these CODING-SYSTEM arguments go away. They
normally get implemented internally to the function by dynamically
binding a variable. That's pretty evil, too, but as long as that is
true (let ((coding-system-for-write codesys)) (write-region ...)) is a
workaround.
Simon> Grep:ing through the XEmacs core I can't find anywhere
Simon> where the CODING-SYSTEM parameter is used. Neither in
Simon> XEmacs mule packages.
Simon> Grep:ing through the XEmacs packages I can find at least
Simon> one place where it is used
Simon> INCORRECTLY. (`ediff-make-empty-tmp-file')
Simon> CODING-SYSTEM is used in jka-compr.el, mule-sysdp.el and
Simon> nnmail.el, but seems to be there just because they provide
Simon> wrappers for write-region.
OK, thanks for checking. Nothing in APEL? That's strange.
Simon> How about ditching the CODING-SYSTEM parameter in favor of
Simon> the MUSTBENEW?
I don't have a problem with this in the long run, given your analysis.
Simon> (Of course, `write-region' could look at the argument to
Simon> see if it is a coding system or not and support both XEmacs
Simon> and Emacs syntax. But it's not nice.)
But as long as we can't prove that somebody somewhere is not using
that argument ....
This is what I would want for 21.4. It's probably the way we should
start in 21.5. You can do a display-warning that the CODESYS usage is
obsolete.
Also, I detest the use of "anything else means ..." in these contexts.
Please document a specific value such as 'ask (or t, I'll bet that's
what the FSF uses when they use it :-( ) for the confirmation. Of
course for compatibility we accept other values (maybe display-warning
about them). We should coordinate with the FSF on this if possible
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."
10:25 a.m.
"Stephen J. Turnbull" <turnbull(a)sk.tsukuba.ac.jp> writes:
Simon> Optional seventh argument CODING-SYSTEM
We should make all of these CODING-SYSTEM arguments go away. They
normally get implemented internally to the function by dynamically
binding a variable. That's pretty evil, too, but as long as that is
true (let ((coding-system-for-write codesys)) (write-region ...)) is a
workaround.
Sounds good.
OK, thanks for checking. Nothing in APEL? That's strange.
I did not check thoroughly. Easiest way is probably to remove the
optional parameter, recompile every lisp in sight and watch the
errors.
Simon> (Of course, `write-region' could look at the
argument to
Simon> see if it is a coding system or not and support both XEmacs
Simon> and Emacs syntax. But it's not nice.)
But as long as we can't prove that somebody somewhere is not using
that argument ....
This is what I would want for 21.4. It's probably the way we should
start in 21.5. You can do a display-warning that the CODESYS usage is
obsolete.
Sounds fair. I'll see if I can come up with a patch.
8489
days inactive
8543
days old
6 comments
5 participants
participants (5)
-
Mike Alexander -
Paul Krause -
Simon Josefsson -
Stephen J. Turnbull -
Yoshiki Hayashi