[PATCH 21.5] Fix g++ build of lwlib-Xaw.c
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2003 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2002 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2001 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2000 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1999 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1998 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
PATCH 21.5
On Tue, Jan 6, 2015 at 9:19 AM, Marcus <marcus.harnisch(a)xemacs.org> wrote:
Jerry James <james(a)xemacs.org> writes:
> Does the compile succeed if you cast to long first, then to int?
Indeed, it does. The secrets of "why" are part of the C++ standard, I
reckon. I am not even getting a warning despite the fact that casting
long to int is lossy.
Stephen already explained the whys and wherefores, so I'll just paste
the patch in here for public consideration.
diff -r 9e5f3a0d4e66 lwlib/ChangeLog
--- a/lwlib/ChangeLog Sat Jan 03 16:24:56 2015 +0100
+++ b/lwlib/ChangeLog Wed Jan 07 09:14:09 2015 -0700
＠＠ -1,3 +1,8 ＠＠
+2015-01-07 Jerry James <james(a)xemacs.org>
+
+ * lwlib-Xaw.c (xaw_scrollbar_scroll): Add typecast to fix g++ build,
+ problem reported by Marcus Harnisch.
+
2013-06-23 Stephen J. Turnbull <stephen(a)xemacs.org>
* XEmacs 21.5.34 "kale" is released.
diff -r 9e5f3a0d4e66 lwlib/lwlib-Xaw.c
--- a/lwlib/lwlib-Xaw.c Sat Jan 03 16:24:56 2015 +0100
+++ b/lwlib/lwlib-Xaw.c Wed Jan 07 09:14:09 2015 -0700
＠＠ -613,10 +613,10 ＠＠
return;
id = instance->info->id;
- event_data.slider_value = (int) call_data;
+ event_data.slider_value = (int) (long) call_data;
event_data.time = 0;
- if ((int) call_data > 0)
+ if ((int) (long) call_data > 0)
/* event_data.action = SCROLLBAR_PAGE_DOWN;*/
event_data.action = SCROLLBAR_LINE_DOWN;
else
--
Jerry James
http://www.jamezone.org/
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
Saturday, 10 January
Sat, 10 Jan
11:10 a.m.
New subject: Fallout from the patch to fix g++ build of lwlib-Xaw.c
In the process of testing Jerry's patch, I got the error below for
LDAP. Any ideas or suggestions? I suspect the problem stems from
ellcc invoking "gcc" rather than "g++" for the link step, but I
don't
know much about ellcc. Jerry?
../../lib-src/ellcc -Wall -Wno-switch -Wundef -Wsign-compare -Wno-char-subscripts -Wpacked
-Wpointer-arith -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes
-Wdeclaration-after-statement -Wunused-parameter -g --mode=compile
--mod-output=eldap_i.o -I../../src
-I/Users/steve/src/XEmacs/21.5/pristine/modules/ldap/../../src -I/opt/local/include -c
eldap_i.c
clang: warning: treating 'c' input as 'c++' when in C++ mode, this
behavior is deprecated
../../lib-src/ellcc --mode=link --mode=verbose --mod-output=eldap.ell \
eldap.o eldap_i.o -Wl,-no_pie -L/usr/X11/lib -lldap -llber
ellcc driver version 21.5-b34 for EMODULES version 1.1.0 (1010)
gcc -Wl,-no_pie -bundle -bundle_loader ../../src/xemacs -o eldap.ell eldap.o eldap_i.o
-Wl,-no_pie -L/usr/X11/lib -lldap -llber
Undefined symbols for architecture x86_64:
"std::terminate()", referenced from:
___clang_call_terminate in eldap.o
"___cxa_begin_catch", referenced from:
___clang_call_terminate in eldap.o
"___gxx_personality_v0", referenced from:
Fldap_search_basic(long, long, long, long, long, long, long, long) in eldap.o
Fldap_add(long, long, long) in eldap.o
Fldap_modify(long, long, long) in eldap.o
Dwarf Exception Unwind Info (__eh_frame) in eldap.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [eldap.ell] Error 1
make: *** [modules/ldap] Error 2
_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta(a)xemacs.org
http://lists.xemacs.org/mailman/listinfo/xemacs-beta
3604
days inactive
3607
days old
1 comments
2 participants
tags (0)
participants (2)
-
Jerry James -
Stephen J. Turnbull