karlheg(a)cathcart.sysc.pdx.edu (Karl M. Hegbloom) writes:
>>>>> "Ben" == Ben Wing <ben(a)666.com>
writes:
Ben> Actually, Oscar, I was suggesting more simple changes,
Ben> i.e. just make your API consistent with general Elisp API
Ben> principles.
Ben> For example:
Ben> -- Instead of ldap-add-internal, just call it ldap-put and
Ben> make it the advertised
Ben> interface. There is no need to provide an interface like
Ben> ldap-add that automatically does an open and a close,
Ben> displays messages, looks for ldap-default-host, etc. Follow
Ben> standard convention and make the caller do this.
But then just about every program that uses it will need to define a
wrapper function that does all that.
The current ldap-add is very inneficient if you are going to be making
anything other than _1_ modification, which isn't usually the case (at
least when I use ldap :)
I was thrown off by the fact that the LDAP routines you are supposed to use
if you make the connection your self are all named 'xxx-internal', which
means (to me) 'DO NOT USE THIS DIRECTLY', etc. Kind of like
open-network-stream-internal and friends.
-Bill P.