5:04 a.m.
The face settings in lisp/faces.el and a few other places used
window-system specific specifications instead of using the generic 'win'
type. This patch changes things like:
(set-face-background 'text-cursor
'(((x default) . "Red3")
((mswindows default) . "Red3"))
'global)
to
(set-face-background 'text-cursor
'(((win default) . "Red3"))
'global)
This has the side-effect that GTK and MacOS faces will get the same
defaults as everything else.
This patch also addresses some default faces not being initialized
correctly in GTK.
-bp
--
Ceterum censeo vi esse delendam
8:41 a.m.
>>>> "-BP" == William M Perry
<wmperry(a)gnu.org> writes:
-BP> The face settings in lisp/faces.el and a few other places
-BP> used window-system specific specifications instead of using
-BP> the generic 'win' type. This patch changes things like:
Yes. There was a comment about "why don't we use 'win instead of the
specific windowing systems?" too, IIRC. Do you know why they didn't
in the first place, or otherwise are you willing to promise that this
won't ever hurt anybody anywhere? ;-)
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
12:15 p.m.
"Stephen J. Turnbull" <stephen(a)xemacs.org> writes:
>>>>> "-BP" == William M Perry
<wmperry(a)gnu.org> writes:
-BP> The face settings in lisp/faces.el and a few other places
-BP> used window-system specific specifications instead of using
-BP> the generic 'win' type. This patch changes things like:
Yes. There was a comment about "why don't we use 'win instead of the
specific windowing systems?" too, IIRC.
I think I put that in during the GTK port, at least somewhere in C land.
Do you know why they didn't in the first place, or otherwise are
you
willing to promise that this won't ever hurt anybody anywhere? ;-)
No clue why they didn't do it in the first place. Might originally have
been envisioning different defaults for windows and X11, but everywhere I
saw these, the specs for (x) vs (mswindows) vs (gtk) were identical.
The only danger I see is someone porting to a windowing system that doesn't
have named colors, or sufficiently different named colors that 'red3'
doesn't work. This could be fixed by simply adding more specs with generic
colors in them. Most already do (highlight is 'darkseagreen2' 'green'),
the noticeable exceptions seem to be text-cursor, list-mode-item-selected,
primary-selection, and gui-button-face.
I could add those and resubmit the patch if you wish. Basically would be:
text-cursor - add red
list-mode-item-selected - gray
primary-selection - gray
gui-button-face - gray
Unless anybody has objections to falling back to just 'gray' instead of
various shades of it....
-bp
--
Ceterum censeo vi esse delendam
12:44 p.m.
wmperry(a)gnu.org (William M. Perry) writes:
The only danger I see is someone porting to a windowing system that
doesn't have named colors, or sufficiently different named colors
that 'red3' doesn't work.
By now "red3" and friends can be considered an XEmacs feature. Take a
look at mswindows_X_color_map in `objects-msw.c'.
One problem are the displays with completely different ideas about
colors, such as color TTYs. There you not only cannot depend on the
color names, but you cannot even define them in a meaningful way.
4:34 p.m.
Hrvoje Niksic <hniksic(a)arsdigita.com> writes:
wmperry(a)gnu.org (William M. Perry) writes:
> The only danger I see is someone porting to a windowing system that
> doesn't have named colors, or sufficiently different named colors
> that 'red3' doesn't work.
By now "red3" and friends can be considered an XEmacs feature. Take a
look at mswindows_X_color_map in `objects-msw.c'.
One problem are the displays with completely different ideas about
colors, such as color TTYs. There you not only cannot depend on the
color names, but you cannot even define them in a meaningful way.
You could specify RGB if we start doing closest-color matching on ttys
colors.
-bp
--
Ceterum censeo vi esse delendam
2:32 p.m.
William M. Perry wrote:
[...]
This has the side-effect that GTK and MacOS faces will get the same
defaults as everything else.
I liked setting GTK specific defaults in gtk-init-device-faces in
gtk-faces.el, using the style information from gtk-style-info, though.
--
John Paul Wallington
4:11 p.m.
John Paul Wallington <jpw(a)shootybangbang.com> writes:
William M. Perry wrote:
[...]
> This has the side-effect that GTK and MacOS faces will get the same
> defaults as everything else.
I liked setting GTK specific defaults in gtk-init-device-faces in
gtk-faces.el, using the style information from gtk-style-info, though.
We could still add this if we want... won't (gtk color) override (win
color)?
We could just do this in gtk-faces.el:
(defmacro gtk-style-munge-face (face attribute value)
(let ((func (intern (format "face-%s" (eval attribute)))))
`(add-spec-to-specifier (,func ,face) ,value nil '(gtk default) 'prepend)))
(let* ((style (gtk-style-info device))
;;(normal 0) ; GTK_STATE_NORMAL
;;(active 1) ; GTK_STATE_ACTIVE
(prelight 2) ; GTK_STATE_PRELIGHT
(selected 3) ; GTK_STATE_SELECTED
;;(insensitive 4) ; GTK_STATE_INSENSITIVE
)
(gtk-style-munge-face 'highlight 'foreground
(nth prelight (plist-get style 'text)))
(gtk-style-munge-face 'highlight 'background
(nth prelight (plist-get style 'background)))
(gtk-style-munge-face 'zmacs-region 'foreground
(nth selected (plist-get style 'text)))
(gtk-style-munge-face 'zmacs-region 'background
(nth selected (plist-get style 'background))))
Look reasonable?
-bp
--
Ceterum censeo vi esse delendam
7:37 p.m.
William M. Perry wrote:
John Paul Wallington <jpw(a)shootybangbang.com> writes:
> William M. Perry wrote:
> [...]
>> This has the side-effect that GTK and MacOS faces will get the
>> same defaults as everything else.
>
> I liked setting GTK specific defaults in gtk-init-device-faces in
> gtk-faces.el, using the style information from gtk-style-info,
> though.
We could still add this if we want... won't (gtk color) override
(win color)?
Yes, it does. I think asking the window-system for default colours is
a good idea if it provides such info.
We could just do this in gtk-faces.el:
[...]
Look reasonable?
Yup, that's neat!
--
John Paul Wallington
2:52 p.m.
Could you guys please take this off xemacs-patches?
--
Cheers =8-} Mike "Review Whip" Sperber
Friede, Völkerverständigung und überhaupt blabla
10:34 p.m.
<Puts on Mr Preprocessor's hat>
xemacs-patches is _not_ the appropriate forum for this kind of
discussion. Please move it to xemacs-beta.
Don't make me come to your office with Mr Preprocessor's naughty
stick. It will hurt, your co-workers will watch, I'll enjoy
it... Hmm, on 2nd thoughts, that could be fun. Go on, I dare you, I
double dare you!
<reluctantly gives back hat and naughty stick>
|--==> "jpw" == John Paul Wallington <jpw(a)shootybangbang.com> writes:
jpw> William M. Perry wrote:
jpw> [...]
>This has the side-effect that GTK and MacOS faces will get the
same
>defaults as everything else.
|--==> "WMP" == William M Perry <wmperry(a)gnu.org> writes:
WMP> John Paul Wallington <jpw(a)shootybangbang.com> writes:
>William M. Perry wrote:
>[...]
|--==> "jpw" == John Paul Wallington <jpw(a)shootybangbang.com> writes:
jpw> William M. Perry wrote:
>John Paul Wallington <jpw(a)shootybangbang.com> writes:
>
>>William M. Perry wrote:
>>[...]
>>>This has the side-effect that GTK and MacOS faces will get the
>>>same defaults as everything else.
>>
>>I liked setting GTK specific defaults in gtk-init-device-faces in
>>gtk-faces.el, using the style information from gtk-style-info,
>>though.
>
>We could still add this if we want... won't (gtk color) override
>(win color)?
jpw> Yes, it does. I think asking the window-system for default colours is
jpw> a good idea if it provides such info.
>We could just do this in gtk-faces.el:
jpw> [...]
>Look reasonable?
jpw> Yup, that's neat!
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
1:27 a.m.
Steve Youngs <youngs(a)xemacs.org> writes:
<Puts on Mr Preprocessor's hat>
xemacs-patches is _not_ the appropriate forum for this kind of
discussion. Please move it to xemacs-beta.
Doh! Didn't realize it was on the cc list still.
Don't make me come to your office with Mr Preprocessor's
naughty stick.
It will hurt, your co-workers will watch, I'll enjoy it... Hmm, on 2nd
thoughts, that could be fun. Go on, I dare you, I double dare you!
Oh yeah?! By the time you got here from australia, I could train my
datschund to chew your kneecaps off. :) And my son is getting pretty good
at karate. :)
-bp
--
Ceterum censeo vi esse delendam
2:02 a.m.
|--==> "WMP" == William M Perry <wmperry(a)gnu.org> writes:
WMP> Steve Youngs <youngs(a)xemacs.org> writes:
>Don't make me come to your office with Mr Preprocessor's
naughty stick.
>It will hurt, your co-workers will watch, I'll enjoy it... Hmm, on 2nd
>thoughts, that could be fun. Go on, I dare you, I double dare you!
WMP> Oh yeah?! By the time you got here from australia, I could train my
WMP> datschund to chew your kneecaps off. :) And my son is getting pretty good
WMP> at karate. :)
I'll make sure I wear my knee pads, to keep your dog and son at bay. :-)
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|
3:18 a.m.
On Fri, 14 Dec 2001 12:02:04 +1000, Steve Youngs <youngs(a)xemacs.org> said:
I'll make sure I wear my knee pads, to keep your dog and son at
bay. :-)
It's the season to fall on your knees, after all.
--
Michael D. Harnois bilocational bivocational
Pastor, Redeemer Lutheran Church Washburn, Iowa
1L, UST School of Law Minneapolis, Minnesota
"Times are bad. Children no longer obey their parents,
and everyone is writing a book." -- Marcus Tullius Cicero
3:35 a.m.
Steve Youngs <youngs(a)xemacs.org> writes:
|--==> "WMP" == William M Perry <wmperry(a)gnu.org>
writes:
WMP> Steve Youngs <youngs(a)xemacs.org> writes:
>>Don't make me come to your office with Mr Preprocessor's naughty
stick.
>>It will hurt, your co-workers will watch, I'll enjoy it... Hmm, on 2nd
>>thoughts, that could be fun. Go on, I dare you, I double dare you!
WMP> Oh yeah?! By the time you got here from australia, I could train my
WMP> datschund to chew your kneecaps off. :) And my son is getting pretty good
WMP> at karate. :)
I'll make sure I wear my knee pads, to keep your dog and son at bay. :-)
You've obviously not seen my son. :) He's on track to be taller than me
(and even the famous Hrvoje Niksic).
-bp
--
Ceterum censeo vi esse delendam
8381
days inactive
8382
days old
13 comments
7 participants
participants (7)
-
Harnois, Michael D. -
Hrvoje Niksic -
John Paul Wallington -
Michael Sperber -
Stephen J. Turnbull -
Steve Youngs -
William M. Perry