>>>> "Gunnar" == Gunnar Evermann
<ge204(a)eng.cam.ac.uk> writes:
Gunnar> exec-installed-p is in apel/path-utils.el
Gunnar> shouldn't there be something like (require 'path-utils)
Gunnar> in image-mode.el?
Probably unnecessary. It's autoloaded if APEL is installed.
Gunnar> do we need to fix the package-index as well (i.e. make
Gunnar> text-modes require apel)>?
Steve went to some trouble to clean dependencies on APEL out of
non-Mule libraries at one point. I don't know whether that's the
right thing to do or not, but this particular example doesn't inspire
me to use APEL. `exec-installed-p' is not a predicate, in fact it
returns a useful value (namely, the full path to the executable).
Then in image-mode.el that value is ignored in favor of the
unqualified name of the executable, which is the worst possible thing
to do.
IMO, either the full path computed by `exec-installed-p' at load time
should be used, or (preferably, I think) `image-start-external-viewer'
should do a condition-case on `start-process' to handle 'file-error.
I'll code that second patch tomorrow unless somebody thinks it's a bad
idea.
--
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Institute of Policy and Planning Sciences Tel/fax: +81 (298) 53-5091
_________________ _________________ _________________ _________________
What are those straight lines for? "XEmacs rules."