Running on windows 98 (with cygwin), The input ring is set
incorrectly when I run bash.
My shell command is set to "c:/Cygwin/bin/bash.exe"
So, shell-mode generates "bash.exe" as the shell when it does
(file-name-nondirectory (process-command ... ))
This causes the (string-equal shell "bash") test to fail.
(defun shell-mode ()
...
;; shell-dependent assignments.
(let ((shell (file-name-nondirectory (car
(process-command (get-buffer-process (current-buffer)))))))
(setq comint-input-ring-file-name
(or (getenv "HISTFILE")
(cond ((string-equal shell "bash") "~/.bash_history")
((string-equal shell "ksh") "~/.sh_history")
(t "~/.history"))))
...
))
So, I would suggest stripping the extension on windows with
file-name-sans-extension.
(if (eq system-type 'windows-nt)
(setq shell (file-name-sans-extension shell)))
If you like this I can submit a patch.
-jeff
Show replies by date
|--==> "JM" == Jeff Mincy <jeff(a)delphioutpost.com> writes:
JM> Running on windows 98 (with cygwin), The input ring is set
JM> incorrectly when I run bash.
JM> My shell command is set to "c:/Cygwin/bin/bash.exe"
JM> So, shell-mode generates "bash.exe" as the shell when it does
JM> (file-name-nondirectory (process-command ... ))
JM> This causes the (string-equal shell "bash") test to fail.
JM> (defun shell-mode ()
JM> ...
JM> ;; shell-dependent assignments.
JM> (let ((shell (file-name-nondirectory (car
JM> (process-command (get-buffer-process (current-buffer)))))))
JM> (setq comint-input-ring-file-name
JM> (or (getenv "HISTFILE")
JM> (cond ((string-equal shell "bash") "~/.bash_history")
JM> ((string-equal shell "ksh") "~/.sh_history")
JM> (t "~/.history"))))
JM> ...
JM> ))
JM> So, I would suggest stripping the extension on windows with
JM> file-name-sans-extension.
JM> (if (eq system-type 'windows-nt)
JM> (setq shell (file-name-sans-extension shell)))
JM> If you like this I can submit a patch.
Fine by me. Ben, you're our resident win guru, what do you think?
--
|---<Steve Youngs>---------------<GnuPG KeyID: 9E7E2820>---|
| XEmacs - It's not just an editor. |
| It's a way of life. |
|------------------------------------<youngs(a)xemacs.org>---|