4:12 p.m.
Hi all
This is with
o XEmacs 21.4 (patch 5) "Civil Service" [Lucid] (i686-pc-cygwin, Mule) of Fri
Oct 26 2001 on VZELL
Try the following:
xemacs -q:
M-x load-library
dictionary
M-x dictionary-search
corba
and then try and click with button 2 on
Common Object Request Broker Architecture
You'll get:
Buffer is read-only: #<buffer "*Dictionary buffer*">
This is because:
button2 runs `mouse-track'
instead of
button2 runs `link-mouse-click'
as suggested by the source code in
/usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el.
From the /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/README:
Version 1.3.1 - 1.3.2
* replaced set-text-properties by remove-text-properties and
add-text-properties because this function is not recommended
within XEmacs (reported by Serge Boiko)
It seems that this change is responsible for the error. Strange enough
in the version 1.2.1, which I used, before dictionary evolved into an
Xemacs package, the code was correct and used to work.
Attached a patch (which at least works for me). Can anybody confirm this behaviour ?
Ciao
Volker
diff -c /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog~
/usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog
*** /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog~ Fri Oct 26 17:05:16
2001
--- /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog Fri Oct 26 17:05:16
2001
***************
*** 1,3 ****
--- 1,10 ----
+ 2001-10-26 Dr. Volker Zell <Dr.Volker.Zell(a)oracle.com>
+
+ * link.el (link-create-link): Reverted replacement of set-text-properties by
+ remove-text-properties and add-text-properties. This change broke [mouse-2]
+ handling in dictionary buffers. (See changelog entry in README labeled
+ Version 1.3.1 - 1.3.2)
+
2001-09-08 Steve Youngs <youngs(a)xemacs.org>
* Initial XEmacs Package version.
diff -c /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el~
/usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el
*** /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el~ Fri Oct 26 17:05:53
2001
--- /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el Fri Oct 26 17:05:53
2001
***************
*** 42,49 ****
link-data ,data
help-echo ,help
link-function ,function)))
! (remove-text-properties start end properties)
! (add-text-properties start end properties)))
(defun link-insert-link (text face function &optional data help)
"Insert the `text' at point to be formatted as link.
--- 42,48 ----
link-data ,data
help-echo ,help
link-function ,function)))
! (set-text-properties start end properties)))
(defun link-insert-link (text face function &optional data help)
"Insert the `text' at point to be formatted as link.
5:48 a.m.
xemacs-patches removed from cc pending discussion.
>>>> "Volker" == Volker Zell <Dr.> writes:
Volker> It seems that this change is responsible for the
Volker> error. Strange enough in the version 1.2.1, which I used,
Volker> before dictionary evolved into an Xemacs package, the code
Volker> was correct and used to work.
Volker> Attached a patch (which at least works for me). Can
Volker> anybody confirm this behaviour ?
Your report indicates that somehow remove-text-properties and/or
add-text-properties is broken, either the docstrings or the
implementations. This at least demands a comment in the source to
indicate that the reversion is to workaround the bug in XEmacs version
21.4.3 or so.
Can you tell what is broken?
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Don't ask how you can "do" free software business;
ask what your business can "do for" free software.
2:29 p.m.
>>>> "Stephen" == Stephen J Turnbull
<stephen(a)xemacs.org> writes:
Stephen> xemacs-patches removed from cc pending discussion.
>>>> "Volker" == Volker Zell <Dr.> writes:
Volker> It seems that this change is responsible for the
Volker> error. Strange enough in the version 1.2.1, which I used,
Volker> before dictionary evolved into an Xemacs package, the code
Volker> was correct and used to work.
Volker> Attached a patch (which at least works for me). Can
Volker> anybody confirm this behaviour ?
Stephen> Your report indicates that somehow remove-text-properties and/or
Stephen> add-text-properties is broken, either the docstrings or the
Stephen> implementations. This at least demands a comment in the source to
Stephen> indicate that the reversion is to workaround the bug in XEmacs version
Stephen> 21.4.3 or so.
Stephen> Can you tell what is broken?
Oooops, I think my brain was broken. remove-text-properties/add-text-properties are not
broken.
It's just that button2 is not defined as link-mouse-click when running under xemacs.
Here is the right patch:
diff -c /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog~
/usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog
*** /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog~ Mon Oct 29 15:27:20
2001
--- /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/ChangeLog Mon Oct 29 15:27:20
2001
***************
*** 1,3 ****
--- 1,8 ----
+ 2001-10-29 Dr. Volker Zell <Dr.Volker.Zell(a)oracle.com>
+
+ * link.el (link-initialize-keymap): Conditionalize on running-xemacs, otherwise
+ button2 doesn't get defined.
+
2001-09-08 Steve Youngs <youngs(a)xemacs.org>
* Initial XEmacs Package version.
diff -c /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el~
/usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el
*** /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el~ Mon Oct 29 15:20:39
2001
--- /usr/local/lib/xemacs/xemacs-packages/lisp/dictionary/link.el Mon Oct 29 15:20:39
2001
***************
*** 109,116 ****
(defun link-initialize-keymap (keymap)
"Defines the necessary bindings inside keymap"
! (define-key keymap [mouse-2] 'link-mouse-click)
! (define-key keymap "\r" 'link-selected)
! (define-key keymap "\M-\r" 'link-selected-all))
(provide 'link)
--- 109,121 ----
(defun link-initialize-keymap (keymap)
"Defines the necessary bindings inside keymap"
! (if (and (boundp 'running-xemacs) running-xemacs)
! (progn
! (define-key keymap [button2] 'link-mouse-click)
! (define-key keymap [(meta button2)] 'link-mouse-click-all))
! (define-key keymap [mouse-2] 'link-mouse-click)
! (define-key keymap [M-mouse-2] 'link-mouse-click-all))
! (define-key keymap [return] 'link-selected)
! (define-key keymap [(meta return)] 'link-selected-all))
(provide 'link)
8540
days inactive
8543
days old
2 comments
2 participants
participants (2)
-
Dr. Volker Zell -
Stephen J. Turnbull